You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Paul Spillman - Software Engineer - Sun UK <Pa...@Sun.COM> on 2002/01/07 11:28:41 UTC
[PATCH] Support for EJB Primary Key class in iPlanet EJBC task (fwd)
Hi,
I submitted this patch just over a week ago and haven't seen
it rejected or committed to CVS.
Has this just been missed in all the backlog of emails over Christmas?
Paul
---------- Forwarded message ----------
Date: 28 Dec 2001 14:51:27 +0000
From: Paul Spillman - Software Engineer - Sun UK <pa...@sun.com>
Reply-To: Ant Developers List <an...@jakarta.apache.org>
To: ant-dev@jakarta.apache.org
Subject: [PATCH] Support for EJB Primary Key class in iPlanet EJBC task
Hi,
The iPlanet ejbc task does not seem to handle the case where you have a
primary key class as a part of your EJB.
The primary key class does not get added to the list of files to be
added to the ejb-jar file.
For general use in iPlanet this is fine, since iPlanet does not require
the primary key class for an EJB and if one is not present it assumes a
simple String key. However, if you have a non-String key or a multi-part
key, you need the primary key class.
The GenericDeploymentTool class handles the primary key class, but the
IPlanetDeploymentTool class which overrides the generic one does not.
Re: [PATCH] Support for EJB Primary Key class in iPlanet EJBC task (fwd)
Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 08 Jan 2002, Conor MacNeill <co...@cortexebusiness.com.au>
wrote:
> Due to the dependency introduced onto BCEL, I'm not sure whether
> ejbjar will be included in nightly builds from now on.
GUMP knows about this optional dependency. 8-)
Stefan
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Support for EJB Primary Key class in iPlanet EJBC task (fwd)
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
Conor MacNeill wrote:
> Paul Spillman - Software Engineer - Sun UK wrote:
>
>>
>> I'll test tomorrows nightly build to make sure it works OK.
>>
>
> Due to the dependency introduced onto BCEL, I'm not sure whether ejbjar
> will be included in nightly builds from now on.
>
Hmmm, looks like Sam is a step ahead of me. Just about all dist-ant
dependencies are there that Sam could lay his hands on, so you should be
able to use the nightly builds.
Cheers
Conor
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Support for EJB Primary Key class in iPlanet EJBC task (fwd)
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
Paul Spillman - Software Engineer - Sun UK wrote:
>
> I'll test tomorrows nightly build to make sure it works OK.
>
Due to the dependency introduced onto BCEL, I'm not sure whether ejbjar
will be included in nightly builds from now on.
Actually, there are few more optional tasks that could be included in
the nightly build if we can satisfy the right dependencies. I'll see
what I can do about that.
Conor
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Support for EJB Primary Key class in iPlanet EJBC task (fwd)
Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 8 Jan 2002, Paul Spillman <Pa...@Sun.COM> wrote:
> The only reason I didn't pick this up was because I was unable to
> build the CVS snapshot because of an error:
>
> /usr/local/src/jakarta-ant/build.xml:198: Class
> org.apache.tools.ant.taskdefs.condition.Or doesn't support the
> nested "isset" element
You need to bootstrap CVS Ant, it is not uncommon that a version of
Ant cannot be built by an older versions.
Stefan
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Support for EJB Primary Key class in iPlanet EJBC task
(fwd)
Posted by Paul Spillman - Software Engineer - Sun UK <Pa...@Sun.COM>.
Conor,
Sorry about that. It was a typing error.
When I first made the changes it was in the source for 1.4.1. I then
checked out a CVS version to create the proper diff and found some formatting
changes in the CVS file versus the 1.4.1 version.
So I decided that since there weren't many changes I would add the bits into
my CVS copy of the file manually. Hence mis-typing ejbFile instead of ejbFiles.
The only reason I didn't pick this up was because I was unable to build the
CVS snapshot because of an error:
/usr/local/src/jakarta-ant/build.xml:198: Class org.apache.tools.ant.taskdefs.condition.Or doesn't support the nested "isset" element
I'll test tomorrows nightly build to make sure it works OK.
Thanks,
Paul
On Tue, 8 Jan 2002, Conor MacNeill wrote:
> Paul,
>
> I applied your patch. Unfortunately it did not compile straight off.
>
> build:
> Compiling 57 source files to
> /home/conor/dev/antdev/jakarta-ant/build/classes
> /home/conor/dev/antdev/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java:1249:
> cannot resolve symbol
> symbol : variable ejbFile
> location: class
> org.apache.tools.ant.taskdefs.optional.ejb.IPlanetEjbc.EjbInfo
> ejbFile.put(pathToFile, pkFile);
> ^
>
> The error is obvious and I have fixed it, but I am concerned. I have
> committed the change - can you test that it works as expected.
>
> Conor
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
---------------------------------------------------------------
Paul Spillman Software Engineer
paul.spillman@sun.com Sun Microsystems Ltd.
ext. 41417 Sun House, 31-41 Pembroke Bdwy,
tel. +44 1276 689417 Camberley, Surrey. GU15 3XD
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Support for EJB Primary Key class in iPlanet EJBC task (fwd)
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
Paul Spillman - Software Engineer - Sun UK wrote:
> Hi,
>
> I submitted this patch just over a week ago and haven't seen
> it rejected or committed to CVS.
>
> Has this just been missed in all the backlog of emails over Christmas?
>
> Paul
>
Paul,
I applied your patch. Unfortunately it did not compile straight off.
build:
Compiling 57 source files to
/home/conor/dev/antdev/jakarta-ant/build/classes
/home/conor/dev/antdev/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java:1249:
cannot resolve symbol
symbol : variable ejbFile
location: class
org.apache.tools.ant.taskdefs.optional.ejb.IPlanetEjbc.EjbInfo
ejbFile.put(pathToFile, pkFile);
^
The error is obvious and I have fixed it, but I am concerned. I have
committed the change - can you test that it works as expected.
Conor
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>