You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/05/29 02:05:56 UTC
Review Request 34791: Views : Add URLConnectionProvider interface
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34791/
-----------------------------------------------------------
Review request for Ambari and Robert Levas.
Bugs: AMBARI-11516
https://issues.apache.org/jira/browse/AMBARI-11516
Repository: ambari
Description
-------
Make an enhancement to view framework to expose a connection provider interface and make it available through the view context.
This is being requested because the existing URLStreamProvider interface can only return a stream and does not provide any http error code or response body on failures.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 9a4aae2
ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java bb3b8aa
ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java b470da2
ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java e606820
ambari-views/src/main/java/org/apache/ambari/view/URLConnectionProvider.java PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 2522486
Diff: https://reviews.apache.org/r/34791/diff/
Testing
-------
New unit tests added.
mvn clean test
all tests pass
Thanks,
Tom Beerbower
Re: Review Request 34791: Views : Add URLConnectionProvider interface
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On May 29, 2015, 1:41 a.m., Robert Levas wrote:
> > Ship It!
Thanks Rob!
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34791/#review85666
-----------------------------------------------------------
On May 29, 2015, 12:34 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34791/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 12:34 a.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Bugs: AMBARI-11516
> https://issues.apache.org/jira/browse/AMBARI-11516
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Make an enhancement to view framework to expose a connection provider interface and make it available through the view context.
>
> This is being requested because the existing URLStreamProvider interface can only return a stream and does not provide any http error code or response body on failures.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 9a4aae2
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java bb3b8aa
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java b470da2
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java e606820
> ambari-views/src/main/java/org/apache/ambari/view/URLConnectionProvider.java PRE-CREATION
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 2522486
>
> Diff: https://reviews.apache.org/r/34791/diff/
>
>
> Testing
> -------
>
> New unit tests added.
>
> mvn clean test
>
> all tests pass
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52:12 min
> [INFO] Finished at: 2015-05-28T19:56:18-04:00
> [INFO] Final Memory: 56M/1220M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 34791: Views : Add URLConnectionProvider interface
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34791/#review85666
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On May 28, 2015, 8:34 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34791/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 8:34 p.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Bugs: AMBARI-11516
> https://issues.apache.org/jira/browse/AMBARI-11516
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Make an enhancement to view framework to expose a connection provider interface and make it available through the view context.
>
> This is being requested because the existing URLStreamProvider interface can only return a stream and does not provide any http error code or response body on failures.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 9a4aae2
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java bb3b8aa
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java b470da2
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java e606820
> ambari-views/src/main/java/org/apache/ambari/view/URLConnectionProvider.java PRE-CREATION
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 2522486
>
> Diff: https://reviews.apache.org/r/34791/diff/
>
>
> Testing
> -------
>
> New unit tests added.
>
> mvn clean test
>
> all tests pass
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52:12 min
> [INFO] Finished at: 2015-05-28T19:56:18-04:00
> [INFO] Final Memory: 56M/1220M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 34791: Views : Add URLConnectionProvider interface
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34791/
-----------------------------------------------------------
(Updated May 29, 2015, 12:34 a.m.)
Review request for Ambari and Robert Levas.
Bugs: AMBARI-11516
https://issues.apache.org/jira/browse/AMBARI-11516
Repository: ambari
Description
-------
Make an enhancement to view framework to expose a connection provider interface and make it available through the view context.
This is being requested because the existing URLStreamProvider interface can only return a stream and does not provide any http error code or response body on failures.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 9a4aae2
ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java bb3b8aa
ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java b470da2
ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java e606820
ambari-views/src/main/java/org/apache/ambari/view/URLConnectionProvider.java PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 2522486
Diff: https://reviews.apache.org/r/34791/diff/
Testing (updated)
-------
New unit tests added.
mvn clean test
all tests pass
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52:12 min
[INFO] Finished at: 2015-05-28T19:56:18-04:00
[INFO] Final Memory: 56M/1220M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower