You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Naveen Neelakantam (JIRA)" <ji...@apache.org> on 2006/10/05 09:55:20 UTC
[jira] Created: (HARMONY-1707) find_stack_* signals_em64t.cpp patch
find_stack_* signals_em64t.cpp patch
------------------------------------
Key: HARMONY-1707
URL: http://issues.apache.org/jira/browse/HARMONY-1707
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Naveen Neelakantam
Attachments: find_stack_info.patch
My pthread_attr_getstackaddr (HARMONY-990) patch was applied to signals_em64t.cpp. However, my patch is not quite right. Gregory Shimansky's patch (HARMONY-977) contains the correct modifications.
Therefore, I've attached a patch that makes the em64t find_stack_size() and find_stack_addr() methods the same as their ia32 equivalents (which use Gregory's patch).
Sorry, I should have noted this before.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1707) find_stack_* signals_em64t.cpp
patch
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1707?page=all ]
Mark Hindess reassigned HARMONY-1707:
-------------------------------------
Assignee: Mark Hindess
> find_stack_* signals_em64t.cpp patch
> ------------------------------------
>
> Key: HARMONY-1707
> URL: http://issues.apache.org/jira/browse/HARMONY-1707
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Naveen Neelakantam
> Assigned To: Mark Hindess
> Attachments: find_stack_info.patch
>
>
> My pthread_attr_getstackaddr (HARMONY-990) patch was applied to signals_em64t.cpp. However, my patch is not quite right. Gregory Shimansky's patch (HARMONY-977) contains the correct modifications.
> Therefore, I've attached a patch that makes the em64t find_stack_size() and find_stack_addr() methods the same as their ia32 equivalents (which use Gregory's patch).
> Sorry, I should have noted this before.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1707) find_stack_* signals_em64t.cpp patch
Posted by "Naveen Neelakantam (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1707?page=all ]
Naveen Neelakantam updated HARMONY-1707:
----------------------------------------
Attachment: find_stack_info.patch
> find_stack_* signals_em64t.cpp patch
> ------------------------------------
>
> Key: HARMONY-1707
> URL: http://issues.apache.org/jira/browse/HARMONY-1707
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Naveen Neelakantam
> Attachments: find_stack_info.patch
>
>
> My pthread_attr_getstackaddr (HARMONY-990) patch was applied to signals_em64t.cpp. However, my patch is not quite right. Gregory Shimansky's patch (HARMONY-977) contains the correct modifications.
> Therefore, I've attached a patch that makes the em64t find_stack_size() and find_stack_addr() methods the same as their ia32 equivalents (which use Gregory's patch).
> Sorry, I should have noted this before.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1707) find_stack_* signals_em64t.cpp
patch
Posted by "Naveen Neelakantam (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1707?page=comments#action_12440060 ]
Naveen Neelakantam commented on HARMONY-1707:
---------------------------------------------
FYI, pthread_attr_getstack returns the lowest addressable byte as the stack_addr. However (as far as I can tell) find_stack_addr is expected to return the highest addressable byte. This patch makes find_stack_addr return the expected value.
> find_stack_* signals_em64t.cpp patch
> ------------------------------------
>
> Key: HARMONY-1707
> URL: http://issues.apache.org/jira/browse/HARMONY-1707
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Naveen Neelakantam
> Attachments: find_stack_info.patch
>
>
> My pthread_attr_getstackaddr (HARMONY-990) patch was applied to signals_em64t.cpp. However, my patch is not quite right. Gregory Shimansky's patch (HARMONY-977) contains the correct modifications.
> Therefore, I've attached a patch that makes the em64t find_stack_size() and find_stack_addr() methods the same as their ia32 equivalents (which use Gregory's patch).
> Sorry, I should have noted this before.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1707) find_stack_* signals_em64t.cpp
patch
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1707?page=all ]
Mark Hindess resolved HARMONY-1707.
-----------------------------------
Resolution: Fixed
Thanks Naveen. Applied in r453132. (No doubt I'd have discovered this problem if I could only get everything to build! ;-)
> find_stack_* signals_em64t.cpp patch
> ------------------------------------
>
> Key: HARMONY-1707
> URL: http://issues.apache.org/jira/browse/HARMONY-1707
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Naveen Neelakantam
> Assigned To: Mark Hindess
> Attachments: find_stack_info.patch
>
>
> My pthread_attr_getstackaddr (HARMONY-990) patch was applied to signals_em64t.cpp. However, my patch is not quite right. Gregory Shimansky's patch (HARMONY-977) contains the correct modifications.
> Therefore, I've attached a patch that makes the em64t find_stack_size() and find_stack_addr() methods the same as their ia32 equivalents (which use Gregory's patch).
> Sorry, I should have noted this before.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira