[GitHub] [hive] nrg4878 commented on a change in pull request #1833: HIVE-24591: Move Beeline To SLF4J Simple Logger

[GitBox <gi...@apache.org>]

nrg4878 commented on a change in pull request #1833:
URL: https://github.com/apache/hive/pull/1833#discussion_r555273362



##########
File path: bin/ext/cli.sh
##########
@@ -28,7 +28,7 @@ updateCli() {
     CLASS=org.apache.hadoop.hive.cli.CliDriver
     JAR=hive-cli-*.jar
   else
-    export HADOOP_CLIENT_OPTS=" -Dproc_beeline $HADOOP_CLIENT_OPTS -Dlog4j.configurationFile=beeline-log4j2.properties"
+    export HADOOP_CLIENT_OPTS="-Dproc_beeline -Dorg.slf4j.simpleLogger.defaultLogLevel=warn $HADOOP_CLIENT_OPTS"

Review comment:
       dumb question? how would users enable debug logging in beeline with this approach ?

##########
File path: beeline/pom.xml
##########
@@ -105,19 +117,40 @@
       <artifactId>super-csv</artifactId>
       <version>${super-csv.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>

Review comment:
       arent we already using slf4j libraries in beeline today? How has this been compiling without explicit dependencies? transitive?
   also we should specify a scope for these dependencies.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org