[jira] [Commented] (HBASE-16967) Excluded shaded java classes from findbugs check

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617009#comment-15617009 ] 

stack commented on HBASE-16967:
-------------------------------

Leaving open but not going to do anything here for now.

I could add this:

{code}
diff --git a/dev-support/findbugs-exclude.xml b/dev-support/findbugs-exclude.xml
index 37d5746..afc6df5 100644
--- a/dev-support/findbugs-exclude.xml
+++ b/dev-support/findbugs-exclude.xml
@@ -18,6 +18,10 @@
 <FindBugsFilter>
   <!-- Nested packages are not included by the Package filter, so we need a regexp... -->
   <Match>
+    <Class name="~.*\.shaded\..*"/>
+  </Match>
+
+  <Match>
     <Class name="~.*\.generated\..*"/>
   </Match>

{code}

... but we don't do findbugs in hbase-protocol-* usually.

Let me get more info on how the complaint comes about. It doesn't seem to happen w/ our top-level findbugs run.

> Excluded shaded java classes from findbugs check
> ------------------------------------------------
>
>                 Key: HBASE-16967
>                 URL: https://issues.apache.org/jira/browse/HBASE-16967
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: stack
>
> Carry over from parent issue. [~Apache9] notes that we get findbugs warnings in hbase-protocol-shaded when a build in this module. The findbugs complaints are about google protobuf that we've relocated and checked in here. Exclude.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)