You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2012/11/09 03:30:12 UTC

[jira] [Created] (HBASE-7134) incrementColumnValue hooks no longer called from anywhere

Andrew Purtell created HBASE-7134:
-------------------------------------

             Summary: incrementColumnValue hooks no longer called from anywhere
                 Key: HBASE-7134
                 URL: https://issues.apache.org/jira/browse/HBASE-7134
             Project: HBase
          Issue Type: Bug
          Components: Coprocessors
    Affects Versions: 0.96.0
            Reporter: Andrew Purtell
            Assignee: Andrew Purtell




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7134) incrementColumnValue hooks no longer called from anywhere

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497499#comment-13497499 ] 

stack commented on HBASE-7134:
------------------------------

+1
                
> incrementColumnValue hooks no longer called from anywhere
> ---------------------------------------------------------
>
>                 Key: HBASE-7134
>                 URL: https://issues.apache.org/jira/browse/HBASE-7134
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.96.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>         Attachments: HBASE-7134.patch
>
>
> incrementColumnValue has been removed from RegionServer, the corresponding coprocessor hooks for this operation are no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7134) incrementColumnValue hooks no longer called from anywhere

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498514#comment-13498514 ] 

Hudson commented on HBASE-7134:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #263 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/263/])
    HBASE-7134. incrementColumnValue hooks no longer called from anywhere (Revision 1409968)

     Result = SUCCESS
apurtell : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java

                
> incrementColumnValue hooks no longer called from anywhere
> ---------------------------------------------------------
>
>                 Key: HBASE-7134
>                 URL: https://issues.apache.org/jira/browse/HBASE-7134
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.96.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7134.patch
>
>
> incrementColumnValue has been removed from RegionServer, the corresponding coprocessor hooks for this operation are no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7134) incrementColumnValue hooks no longer called from anywhere

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-7134:
----------------------------------

    Attachment: HBASE-7134.patch

Attached patch removes dead code from RegionCoprocessorHost and deprecates the affected coprocessor hooks in the API. 

A better option might be to remove the hooks rather than deprecate, it would avoid collecting cruft in the list of hooks, but would break any existing coprocessors that overrode this hook from BaseRegionObserver.
                
> incrementColumnValue hooks no longer called from anywhere
> ---------------------------------------------------------
>
>                 Key: HBASE-7134
>                 URL: https://issues.apache.org/jira/browse/HBASE-7134
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.96.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>         Attachments: HBASE-7134.patch
>
>
> incrementColumnValue has been removed from RegionServer, the corresponding coprocessor hooks for this operation are no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7134) incrementColumnValue hooks no longer called from anywhere

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498413#comment-13498413 ] 

Hudson commented on HBASE-7134:
-------------------------------

Integrated in HBase-TRUNK #3547 (See [https://builds.apache.org/job/HBase-TRUNK/3547/])
    HBASE-7134. incrementColumnValue hooks no longer called from anywhere (Revision 1409968)

     Result = FAILURE
apurtell : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java

                
> incrementColumnValue hooks no longer called from anywhere
> ---------------------------------------------------------
>
>                 Key: HBASE-7134
>                 URL: https://issues.apache.org/jira/browse/HBASE-7134
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.96.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7134.patch
>
>
> incrementColumnValue has been removed from RegionServer, the corresponding coprocessor hooks for this operation are no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-7134) incrementColumnValue hooks no longer called from anywhere

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell resolved HBASE-7134.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.96.0
     Hadoop Flags: Reviewed

Committed to trunk. Thanks for the look Stack. Observer unit tests pass locally.
                
> incrementColumnValue hooks no longer called from anywhere
> ---------------------------------------------------------
>
>                 Key: HBASE-7134
>                 URL: https://issues.apache.org/jira/browse/HBASE-7134
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.96.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7134.patch
>
>
> incrementColumnValue has been removed from RegionServer, the corresponding coprocessor hooks for this operation are no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7134) incrementColumnValue hooks no longer called from anywhere

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-7134:
----------------------------------

    Description: incrementColumnValue has been removed from RegionServer, the corresponding coprocessor hooks for this operation are no longer called.
    
> incrementColumnValue hooks no longer called from anywhere
> ---------------------------------------------------------
>
>                 Key: HBASE-7134
>                 URL: https://issues.apache.org/jira/browse/HBASE-7134
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.96.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>
> incrementColumnValue has been removed from RegionServer, the corresponding coprocessor hooks for this operation are no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira