You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Martin Kool (JIRA)" <ad...@incubator.apache.org> on 2006/08/11 09:41:13 UTC
[jira] Created: (ADFFACES-121) The url part in the css rule
background:url("foo") is not being translated the same way as
background-image:url("foo")
The url part in the css rule background:url("foo") is not being translated the same way as background-image:url("foo")
----------------------------------------------------------------------------------------------------------------------
Key: ADFFACES-121
URL: http://issues.apache.org/jira/browse/ADFFACES-121
Project: MyFaces ADF-Faces
Issue Type: Bug
Components: Skinning
Environment: All
Reporter: Martin Kool
Priority: Minor
It seems that in CSS-3 selectors, a url specified in "background-image" is being converted correctly, whereas the same url specified in "backgroun" is not.
For example, the following two lines of css:
background: url("../../afr/dropdown_n.gif");
background-image: url("../../afr/dropdown_n.gif");
get converted to
background:url("../../afr/dropdown_n.gif");
background-image:url("/adf-richclient-demo-context-root/afr/dropdown_n.gif")
So currently people can use background-url as a workaround, but this should be supported at some time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (ADFFACES-121) The url part in the css rule
background:url("foo") is not being translated the same way as
background-image:url("foo")
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-121?page=all ]
Adam Winer resolved ADFFACES-121.
---------------------------------
Resolution: Fixed
> The url part in the css rule background:url("foo") is not being translated the same way as background-image:url("foo")
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ADFFACES-121
> URL: http://issues.apache.org/jira/browse/ADFFACES-121
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Environment: All
> Reporter: Martin Kool
> Priority: Minor
> Attachments: ADFFACES-121.patch, ADFFACES-121_v2.patch, ADFFACES-121_v3.patch
>
>
> It seems that in CSS-3 selectors, a url specified in "background-image" is being converted correctly, whereas the same url specified in "backgroun" is not.
> For example, the following two lines of css:
> background: url("../../afr/dropdown_n.gif");
> background-image: url("../../afr/dropdown_n.gif");
> get converted to
> background:url("../../afr/dropdown_n.gif");
> background-image:url("/adf-richclient-demo-context-root/afr/dropdown_n.gif")
> So currently people can use background-url as a workaround, but this should be supported at some time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-121) The url part in the css rule
background:url("foo") is not being translated the same way as
background-image:url("foo")
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-121?page=all ]
Simon Lessard updated ADFFACES-121:
-----------------------------------
Attachment: ADFFACES-121_v2.patch
This patch applies Adam's suggestions:
Convert url(); anything other than than this syntax gets dropped
and logged with a warning
- URLs beginning with a slash get prefixed with the context root
(like other such URLs in JSF)
- URLs beginning with two slashes get trimmed to a single slash
(special Trinidad URL rule, already used in Trinidad components)
- Relative URLs get interpreted as relative to the original .css file,
and converted so that they are still valid references to the
desired file.
- Other URLs (e.g., URLs with server names) are left alone.
> The url part in the css rule background:url("foo") is not being translated the same way as background-image:url("foo")
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ADFFACES-121
> URL: http://issues.apache.org/jira/browse/ADFFACES-121
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Environment: All
> Reporter: Martin Kool
> Priority: Minor
> Attachments: ADFFACES-121.patch, ADFFACES-121_v2.patch
>
>
> It seems that in CSS-3 selectors, a url specified in "background-image" is being converted correctly, whereas the same url specified in "backgroun" is not.
> For example, the following two lines of css:
> background: url("../../afr/dropdown_n.gif");
> background-image: url("../../afr/dropdown_n.gif");
> get converted to
> background:url("../../afr/dropdown_n.gif");
> background-image:url("/adf-richclient-demo-context-root/afr/dropdown_n.gif")
> So currently people can use background-url as a workaround, but this should be supported at some time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-121) The url part in the css rule
background:url("foo") is not being translated the same way as
background-image:url("foo")
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-121?page=all ]
Simon Lessard updated ADFFACES-121:
-----------------------------------
Attachment: ADFFACES-121_v3.patch
Fixed the issue with compound property values. Also had to add a hack for ContextImageIcon since the previous patch was killing most skin icons.
> The url part in the css rule background:url("foo") is not being translated the same way as background-image:url("foo")
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ADFFACES-121
> URL: http://issues.apache.org/jira/browse/ADFFACES-121
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Environment: All
> Reporter: Martin Kool
> Priority: Minor
> Attachments: ADFFACES-121.patch, ADFFACES-121_v2.patch, ADFFACES-121_v3.patch
>
>
> It seems that in CSS-3 selectors, a url specified in "background-image" is being converted correctly, whereas the same url specified in "backgroun" is not.
> For example, the following two lines of css:
> background: url("../../afr/dropdown_n.gif");
> background-image: url("../../afr/dropdown_n.gif");
> get converted to
> background:url("../../afr/dropdown_n.gif");
> background-image:url("/adf-richclient-demo-context-root/afr/dropdown_n.gif")
> So currently people can use background-url as a workaround, but this should be supported at some time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-121) The url part in the css rule
background:url("foo") is not being translated the same way as
background-image:url("foo")
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-121?page=all ]
Simon Lessard updated ADFFACES-121:
-----------------------------------
Status: Patch Available (was: Open)
> The url part in the css rule background:url("foo") is not being translated the same way as background-image:url("foo")
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ADFFACES-121
> URL: http://issues.apache.org/jira/browse/ADFFACES-121
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Environment: All
> Reporter: Martin Kool
> Priority: Minor
> Attachments: ADFFACES-121.patch
>
>
> It seems that in CSS-3 selectors, a url specified in "background-image" is being converted correctly, whereas the same url specified in "backgroun" is not.
> For example, the following two lines of css:
> background: url("../../afr/dropdown_n.gif");
> background-image: url("../../afr/dropdown_n.gif");
> get converted to
> background:url("../../afr/dropdown_n.gif");
> background-image:url("/adf-richclient-demo-context-root/afr/dropdown_n.gif")
> So currently people can use background-url as a workaround, but this should be supported at some time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-121) The url part in the css rule
background:url("foo") is not being translated the same way as
background-image:url("foo")
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-121?page=comments#action_12428345 ]
Adam Winer commented on ADFFACES-121:
-------------------------------------
Applied this patch - but it doesn't fully fix the issue. "background" is a compound property, so url() can appear right in the middle (and not be the whole thing). Some examples:
background: red url("pendant.gif");
background: url("banner.jpeg") top center
background: 50% repeat fixed url("chess.png") gray
> The url part in the css rule background:url("foo") is not being translated the same way as background-image:url("foo")
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ADFFACES-121
> URL: http://issues.apache.org/jira/browse/ADFFACES-121
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Environment: All
> Reporter: Martin Kool
> Priority: Minor
> Attachments: ADFFACES-121.patch, ADFFACES-121_v2.patch
>
>
> It seems that in CSS-3 selectors, a url specified in "background-image" is being converted correctly, whereas the same url specified in "backgroun" is not.
> For example, the following two lines of css:
> background: url("../../afr/dropdown_n.gif");
> background-image: url("../../afr/dropdown_n.gif");
> get converted to
> background:url("../../afr/dropdown_n.gif");
> background-image:url("/adf-richclient-demo-context-root/afr/dropdown_n.gif")
> So currently people can use background-url as a workaround, but this should be supported at some time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-121) The url part in the css rule
background:url("foo") is not being translated the same way as
background-image:url("foo")
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-121?page=all ]
Adam Winer updated ADFFACES-121:
--------------------------------
Status: Open (was: Patch Available)
> The url part in the css rule background:url("foo") is not being translated the same way as background-image:url("foo")
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ADFFACES-121
> URL: http://issues.apache.org/jira/browse/ADFFACES-121
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Environment: All
> Reporter: Martin Kool
> Priority: Minor
> Attachments: ADFFACES-121.patch, ADFFACES-121_v2.patch
>
>
> It seems that in CSS-3 selectors, a url specified in "background-image" is being converted correctly, whereas the same url specified in "backgroun" is not.
> For example, the following two lines of css:
> background: url("../../afr/dropdown_n.gif");
> background-image: url("../../afr/dropdown_n.gif");
> get converted to
> background:url("../../afr/dropdown_n.gif");
> background-image:url("/adf-richclient-demo-context-root/afr/dropdown_n.gif")
> So currently people can use background-url as a workaround, but this should be supported at some time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-121) The url part in the css rule
background:url("foo") is not being translated the same way as
background-image:url("foo")
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-121?page=all ]
Simon Lessard updated ADFFACES-121:
-----------------------------------
Attachment: ADFFACES-121.patch
This patch will convert all relative (relative url does not start with '/') url specified within url( ) inside skin properties to a correct context relative url. It will also consider background-image value as an URL even if not enclosed within url( ).
> The url part in the css rule background:url("foo") is not being translated the same way as background-image:url("foo")
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ADFFACES-121
> URL: http://issues.apache.org/jira/browse/ADFFACES-121
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Environment: All
> Reporter: Martin Kool
> Priority: Minor
> Attachments: ADFFACES-121.patch
>
>
> It seems that in CSS-3 selectors, a url specified in "background-image" is being converted correctly, whereas the same url specified in "backgroun" is not.
> For example, the following two lines of css:
> background: url("../../afr/dropdown_n.gif");
> background-image: url("../../afr/dropdown_n.gif");
> get converted to
> background:url("../../afr/dropdown_n.gif");
> background-image:url("/adf-richclient-demo-context-root/afr/dropdown_n.gif")
> So currently people can use background-url as a workaround, but this should be supported at some time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira