[GitHub] [helix] narendly opened a new pull request #400: TASK: Drop all tasks whose requested states are DROPPED

[GitBox <gi...@apache.org>]

narendly opened a new pull request #400: TASK: Drop all tasks whose requested states are DROPPED
URL: https://github.com/apache/helix/pull/400
 
 
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR title:
   
   Fixes #375 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Upon a Participant disconnect, the Participant would carry over from the last session. This would copy all previous task states to the current session and set their requested states as DROPPED (for INIT and RUNNING states).
   
   It came to our attention that sometimes these Participants experience connection issues and the tasks happen to be in TASK_ERROR or COMPLETED states. These tasks would get stuck on the Participant and never be dropped. This issue proposes to add the logic that would get all tasks whose requested states are DROPPED to be dropped immediately.
   Changelist:
   1. Make sure all tasks whose requested state is DROPPED get added to tasksToDrop
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   Manually tested by modifying currentState to the following with the right timing parameters (for task duration). Integration tests that depend on timing are not desirable, so manual testing was done and checked that all CurrentStates that look like the following do not show up:
   
     "mapFields" : {
       "testDropCompletedTasksOnReset_JOB_7_2" : {
         "CURRENT_STATE" : "COMPLETED",
         "REQUESTED_STATE" : "DROPPED"
       },
       "testDropCompletedTasksOnReset_JOB_7_5" : {
         "CURRENT_STATE" : "COMPLETED",
         "REQUESTED_STATE" : "DROPPED"
       },
       "testDropCompletedTasksOnReset_JOB_7_6" : {
         "CURRENT_STATE" : "COMPLETED",
         "REQUESTED_STATE" : "DROPPED"
       }
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   (Copy & paste the result of "mvn test")
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org