You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by sh...@inmobi.com on 2014/06/09 11:33:20 UTC

Re: Review Request 20696: OOZIE-1807 Make bundle change command synchronous

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20696/#review45063
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/20696/#comment79750>

    Increasing the end time of killed coord is allowed with coord change API. So, why not allow bundle change as well if coord is killed


- shwethags


On April 25, 2014, 1:41 a.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20696/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 1:41 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1807
>     https://issues.apache.org/jira/browse/OOZIE-1807
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-1807 Make bundle change command synchronous
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java f26e33b 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java e5afdc7 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java c791474 
>   core/src/main/java/org/apache/oozie/BaseEngine.java 135a0a3 
>   core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf 
>   core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 8b573ce 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java fb31e9a 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 8941a02 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 487a371 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791 
>   core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 6560db6 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 327ec90 
>   core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 9892d4b 
> 
> Diff: https://reviews.apache.org/r/20696/diff/
> 
> 
> Testing
> -------
> 
> UTC and manual testing.
> 
> purushah$ /Users/purushah/views/sysc_command/oozie/distro/target/oozie-4.1.0-SNAPSHOT-distro/oozie-4.1.0-SNAPSHOT/bin/oozie job -change 0000002-140424165425407-oozie-puru-B  -value endtime=2013-01-01T00:00Z -oozie http://localhost:11000/oozie
> Change command for coord job : 0000004-140424165425407-oozie-puru-C failed. Reason : Coord is in killed state
> Change command for coord job : 0000003-140424165425407-oozie-puru-C failed. Reason : Coord is in killed state
> 
> purushah$ 
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>