You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/04/22 13:09:36 UTC
Review Request: fix the sting formatting error in cloudConnection.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10702/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Description
-------
fix the sting formatting error in cloudConnection.py
error seen:
Traceback (most recent call last):
File "/usr/local/bin/nosetests-2.7", line 9, in <module>
load_entry_point('nose==1.2.1', 'console_scripts', 'nosetests-2.7')()
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 118, in __init__
**extra_args)
File "/usr/local/lib/python2.7/unittest/main.py", line 94, in __init__
self.parseArgs(argv)
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 135, in parseArgs
self.config.configure(argv, doc=self.usage())
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/config.py", line 338, in configure
self.plugins.configure(options, self)
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 284, in configure
cfg(options, config)
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 99, in __call__
return self.call(*arg, **kw)
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 167, in simple
result = meth(*arg, **kw)
File "/usr/local/lib/python2.7/site-packages/marvin_nose-0.1.0-py2.7.egg/marvinPlugin.py", line 42, in configure
deploy.loadCfg() if options.load else deploy.deploy()
File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 452, in deploy
self.loadCfg()
File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 409, in loadCfg
apiKey, securityKey = self.registerApiKey()
File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 349, in registerApiKey
listuserRes = self.testClient.getApiClient().listUsers(listuser)
File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 436, in listUsers
response = self.connection.marvin_request(command, data=postdata, response_type=response)
File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 212, in marvin_request
cmdname, auth=False, payload=payload, data=data)
File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 141, in request
(self.baseurl, c))
TypeError: not all arguments converted during string formatting
This addresses bug CLOUDSTACK-2135.
Diffs
-----
tools/marvin/marvin/cloudstackConnection.py 14b12e7
Diff: https://reviews.apache.org/r/10702/diff/
Testing
-------
tested
Thanks,
SrikanteswaraRao Talluri
Re: Review Request: fix the string formatting error in cloudConnection.py
Posted by Rohit Yadav <bh...@apache.org>.
> On April 25, 2013, 4:10 a.m., Rohit Yadav wrote:
> > +1
> > Not applied on src tree though, we'll wait for tsp to respond and commit.
Oh, already committed, only saw the diff first. Closing as submitted.
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10702/#review19689
-----------------------------------------------------------
On April 22, 2013, 11:21 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10702/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 11:21 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> fix the string formatting error in cloudConnection.py
>
> error seen:
>
> Traceback (most recent call last):
> File "/usr/local/bin/nosetests-2.7", line 9, in <module>
> load_entry_point('nose==1.2.1', 'console_scripts', 'nosetests-2.7')()
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 118, in __init__
> **extra_args)
> File "/usr/local/lib/python2.7/unittest/main.py", line 94, in __init__
> self.parseArgs(argv)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 135, in parseArgs
> self.config.configure(argv, doc=self.usage())
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/config.py", line 338, in configure
> self.plugins.configure(options, self)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 284, in configure
> cfg(options, config)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 99, in __call__
> return self.call(*arg, **kw)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 167, in simple
> result = meth(*arg, **kw)
> File "/usr/local/lib/python2.7/site-packages/marvin_nose-0.1.0-py2.7.egg/marvinPlugin.py", line 42, in configure
> deploy.loadCfg() if options.load else deploy.deploy()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 452, in deploy
> self.loadCfg()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 409, in loadCfg
> apiKey, securityKey = self.registerApiKey()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 349, in registerApiKey
> listuserRes = self.testClient.getApiClient().listUsers(listuser)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 436, in listUsers
> response = self.connection.marvin_request(command, data=postdata, response_type=response)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 212, in marvin_request
> cmdname, auth=False, payload=payload, data=data)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 141, in request
> (self.baseurl, c))
> TypeError: not all arguments converted during string formatting
>
>
> This addresses bug CLOUDSTACK-2135.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py 14b12e7
>
> Diff: https://reviews.apache.org/r/10702/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: fix the string formatting error in cloudConnection.py
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10702/#review19689
-----------------------------------------------------------
Ship it!
+1
Not applied on src tree though, we'll wait for tsp to respond and commit.
- Rohit Yadav
On April 22, 2013, 11:21 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10702/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 11:21 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> fix the string formatting error in cloudConnection.py
>
> error seen:
>
> Traceback (most recent call last):
> File "/usr/local/bin/nosetests-2.7", line 9, in <module>
> load_entry_point('nose==1.2.1', 'console_scripts', 'nosetests-2.7')()
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 118, in __init__
> **extra_args)
> File "/usr/local/lib/python2.7/unittest/main.py", line 94, in __init__
> self.parseArgs(argv)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 135, in parseArgs
> self.config.configure(argv, doc=self.usage())
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/config.py", line 338, in configure
> self.plugins.configure(options, self)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 284, in configure
> cfg(options, config)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 99, in __call__
> return self.call(*arg, **kw)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 167, in simple
> result = meth(*arg, **kw)
> File "/usr/local/lib/python2.7/site-packages/marvin_nose-0.1.0-py2.7.egg/marvinPlugin.py", line 42, in configure
> deploy.loadCfg() if options.load else deploy.deploy()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 452, in deploy
> self.loadCfg()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 409, in loadCfg
> apiKey, securityKey = self.registerApiKey()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 349, in registerApiKey
> listuserRes = self.testClient.getApiClient().listUsers(listuser)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 436, in listUsers
> response = self.connection.marvin_request(command, data=postdata, response_type=response)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 212, in marvin_request
> cmdname, auth=False, payload=payload, data=data)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 141, in request
> (self.baseurl, c))
> TypeError: not all arguments converted during string formatting
>
>
> This addresses bug CLOUDSTACK-2135.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py 14b12e7
>
> Diff: https://reviews.apache.org/r/10702/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: fix the string formatting error in cloudConnection.py
Posted by Prasanna Santhanam <Pr...@citrix.com>.
> On April 22, 2013, 2:19 p.m., Prasanna Santhanam wrote:
> >
9572f576483796beb85c7aeb5e0ce3925aee9e42
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10702/#review19523
-----------------------------------------------------------
On April 22, 2013, 11:21 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10702/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 11:21 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> fix the string formatting error in cloudConnection.py
>
> error seen:
>
> Traceback (most recent call last):
> File "/usr/local/bin/nosetests-2.7", line 9, in <module>
> load_entry_point('nose==1.2.1', 'console_scripts', 'nosetests-2.7')()
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 118, in __init__
> **extra_args)
> File "/usr/local/lib/python2.7/unittest/main.py", line 94, in __init__
> self.parseArgs(argv)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 135, in parseArgs
> self.config.configure(argv, doc=self.usage())
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/config.py", line 338, in configure
> self.plugins.configure(options, self)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 284, in configure
> cfg(options, config)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 99, in __call__
> return self.call(*arg, **kw)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 167, in simple
> result = meth(*arg, **kw)
> File "/usr/local/lib/python2.7/site-packages/marvin_nose-0.1.0-py2.7.egg/marvinPlugin.py", line 42, in configure
> deploy.loadCfg() if options.load else deploy.deploy()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 452, in deploy
> self.loadCfg()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 409, in loadCfg
> apiKey, securityKey = self.registerApiKey()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 349, in registerApiKey
> listuserRes = self.testClient.getApiClient().listUsers(listuser)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 436, in listUsers
> response = self.connection.marvin_request(command, data=postdata, response_type=response)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 212, in marvin_request
> cmdname, auth=False, payload=payload, data=data)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 141, in request
> (self.baseurl, c))
> TypeError: not all arguments converted during string formatting
>
>
> This addresses bug CLOUDSTACK-2135.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py 14b12e7
>
> Diff: https://reviews.apache.org/r/10702/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: fix the string formatting error in cloudConnection.py
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10702/#review19523
-----------------------------------------------------------
Ship it!
- Prasanna Santhanam
On April 22, 2013, 11:21 a.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10702/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 11:21 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> fix the string formatting error in cloudConnection.py
>
> error seen:
>
> Traceback (most recent call last):
> File "/usr/local/bin/nosetests-2.7", line 9, in <module>
> load_entry_point('nose==1.2.1', 'console_scripts', 'nosetests-2.7')()
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 118, in __init__
> **extra_args)
> File "/usr/local/lib/python2.7/unittest/main.py", line 94, in __init__
> self.parseArgs(argv)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 135, in parseArgs
> self.config.configure(argv, doc=self.usage())
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/config.py", line 338, in configure
> self.plugins.configure(options, self)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 284, in configure
> cfg(options, config)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 99, in __call__
> return self.call(*arg, **kw)
> File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 167, in simple
> result = meth(*arg, **kw)
> File "/usr/local/lib/python2.7/site-packages/marvin_nose-0.1.0-py2.7.egg/marvinPlugin.py", line 42, in configure
> deploy.loadCfg() if options.load else deploy.deploy()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 452, in deploy
> self.loadCfg()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 409, in loadCfg
> apiKey, securityKey = self.registerApiKey()
> File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 349, in registerApiKey
> listuserRes = self.testClient.getApiClient().listUsers(listuser)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 436, in listUsers
> response = self.connection.marvin_request(command, data=postdata, response_type=response)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 212, in marvin_request
> cmdname, auth=False, payload=payload, data=data)
> File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 141, in request
> (self.baseurl, c))
> TypeError: not all arguments converted during string formatting
>
>
> This addresses bug CLOUDSTACK-2135.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py 14b12e7
>
> Diff: https://reviews.apache.org/r/10702/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: fix the string formatting error in cloudConnection.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10702/
-----------------------------------------------------------
(Updated April 22, 2013, 11:21 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Summary (updated)
-----------------
fix the string formatting error in cloudConnection.py
Description (updated)
-------
fix the string formatting error in cloudConnection.py
error seen:
Traceback (most recent call last):
File "/usr/local/bin/nosetests-2.7", line 9, in <module>
load_entry_point('nose==1.2.1', 'console_scripts', 'nosetests-2.7')()
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 118, in __init__
**extra_args)
File "/usr/local/lib/python2.7/unittest/main.py", line 94, in __init__
self.parseArgs(argv)
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/core.py", line 135, in parseArgs
self.config.configure(argv, doc=self.usage())
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/config.py", line 338, in configure
self.plugins.configure(options, self)
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 284, in configure
cfg(options, config)
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 99, in __call__
return self.call(*arg, **kw)
File "/usr/local/lib/python2.7/site-packages/nose-1.2.1-py2.7.egg/nose/plugins/manager.py", line 167, in simple
result = meth(*arg, **kw)
File "/usr/local/lib/python2.7/site-packages/marvin_nose-0.1.0-py2.7.egg/marvinPlugin.py", line 42, in configure
deploy.loadCfg() if options.load else deploy.deploy()
File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 452, in deploy
self.loadCfg()
File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 409, in loadCfg
apiKey, securityKey = self.registerApiKey()
File "/usr/local/lib/python2.7/site-packages/marvin/deployDataCenter.py", line 349, in registerApiKey
listuserRes = self.testClient.getApiClient().listUsers(listuser)
File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 436, in listUsers
response = self.connection.marvin_request(command, data=postdata, response_type=response)
File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 212, in marvin_request
cmdname, auth=False, payload=payload, data=data)
File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 141, in request
(self.baseurl, c))
TypeError: not all arguments converted during string formatting
This addresses bug CLOUDSTACK-2135.
Diffs
-----
tools/marvin/marvin/cloudstackConnection.py 14b12e7
Diff: https://reviews.apache.org/r/10702/diff/
Testing
-------
tested
Thanks,
SrikanteswaraRao Talluri