You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/10/02 02:27:06 UTC
Review Request 14436: Added a task reconciliation test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14436/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-711
https://issues.apache.org/jira/browse/MESOS-711
Repository: mesos-git
Description
-------
This adds a test for https://reviews.apache.org/r/14435/
Diffs
-----
src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808
Diff: https://reviews.apache.org/r/14436/diff/
Testing
-------
make check and ran with 1400 iterations.
Thanks,
Ben Mahler
Re: Review Request 14436: Added a task reconciliation test.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 2, 2013, 1:05 a.m., Vinod Kone wrote:
> > src/tests/slave_recovery_tests.cpp, line 1855
> > <https://reviews.apache.org/r/14436/diff/1/?file=360252#file360252line1855>
> >
> > s/executor//
> >
> > All of our slave recovery tests, including this, use command executor which doesn't have any resources :(
Done, added a TODO for using an explicit executor here.
> On Oct. 2, 2013, 1:05 a.m., Vinod Kone wrote:
> > src/tests/slave_recovery_tests.cpp, lines 1982-1985
> > <https://reviews.apache.org/r/14436/diff/1/?file=360252#file360252line1982>
> >
> > Kill?
Thanks!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14436/#review26587
-----------------------------------------------------------
On Oct. 2, 2013, 12:27 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14436/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 12:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-711
> https://issues.apache.org/jira/browse/MESOS-711
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This adds a test for https://reviews.apache.org/r/14435/
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808
>
> Diff: https://reviews.apache.org/r/14436/diff/
>
>
> Testing
> -------
>
> make check and ran with 1400 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 14436: Added a task reconciliation test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14436/#review26587
-----------------------------------------------------------
Ship it!
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/14436/#comment51832>
s/executor//
All of our slave recovery tests, including this, use command executor which doesn't have any resources :(
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/14436/#comment51829>
s/ack/_statusUpdateAcknowledgement/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/14436/#comment51830>
s/, now/ so that/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/14436/#comment51831>
Kill?
- Vinod Kone
On Oct. 2, 2013, 12:27 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14436/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 12:27 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-711
> https://issues.apache.org/jira/browse/MESOS-711
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This adds a test for https://reviews.apache.org/r/14435/
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808
>
> Diff: https://reviews.apache.org/r/14436/diff/
>
>
> Testing
> -------
>
> make check and ran with 1400 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 14436: Added a task reconciliation test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14436/
-----------------------------------------------------------
(Updated Oct. 2, 2013, 5:45 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Vinod's review.
Bugs: MESOS-711
https://issues.apache.org/jira/browse/MESOS-711
Repository: mesos-git
Description
-------
This adds a test for https://reviews.apache.org/r/14435/
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808
Diff: https://reviews.apache.org/r/14436/diff/
Testing
-------
make check and ran with 1400 iterations.
Thanks,
Ben Mahler