You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2021/05/09 05:01:19 UTC
[superset] branch control-section-touchups created (now b0c9c59)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a change to branch control-section-touchups
in repository https://gitbox.apache.org/repos/asf/superset.git.
at b0c9c59 fixing a space for the linter :/
This branch includes the following new commits:
new 994b9c8 simplifying tabOverride logic
new 98d33ce clarifying docs
new b0c9c59 fixing a space for the linter :/
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 02/03: clarifying docs
Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch control-section-touchups
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 98d33ce3eeb2fe6cadd8ec9f872474439e7a5c8a
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Mon Nov 30 23:54:35 2020 -0800
clarifying docs
---
superset-frontend/src/explore/controls.jsx | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/explore/controls.jsx b/superset-frontend/src/explore/controls.jsx
index 22ae582..bbdb896 100644
--- a/superset-frontend/src/explore/controls.jsx
+++ b/superset-frontend/src/explore/controls.jsx
@@ -37,7 +37,10 @@
* - renderTrigger: a bool that defines whether the visualization should be re-rendered
when changed. This should `true` for controls that only affect the rendering (client side)
and don't affect the query or backend data processing as those require to re run a query
- and fetch the data
+ and fetch the data. Note that if ALL controls in a seciton are set to "renderTrigger: true"
+ the section will appear in the "Customize" tab rather than the "Data" tab. You can add a
+ "tabOverride" parameter to the controls section with a value of "data" or "customize" if
+ you'd like to override this behavior either way
* - validators: an array of functions that will receive the value of the component and
should return error messages when the value is not valid. The error message gets
bubbled up to the control header, section header and query panel header.
@@ -48,9 +51,7 @@
anything external to it, like another control's value. For instance it's possible to
show a warning based on the value of another component. It's also possible to bind
arbitrary data from the redux store to the component this way.
- * - tabOverride: set to 'data' if you want to force a renderTrigger to show up on the `Data`
- tab, or 'customize' if you want it to show up on that tam. Otherwise sections with ALL
- `renderTrigger: true` components will show up on the `Customize` tab.
+
*
* Note that the keys defined in controls in this file that are not listed above represent
* props specific for the React component defined as `type`. Also note that this module work
[superset] 03/03: fixing a space for the linter :/
Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch control-section-touchups
in repository https://gitbox.apache.org/repos/asf/superset.git
commit b0c9c59ce4f0c9f0034e3b060a654742a21e6e1b
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Tue Dec 1 15:49:45 2020 -0800
fixing a space for the linter :/
---
superset-frontend/src/explore/controls.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset-frontend/src/explore/controls.jsx b/superset-frontend/src/explore/controls.jsx
index bbdb896..eed6e33 100644
--- a/superset-frontend/src/explore/controls.jsx
+++ b/superset-frontend/src/explore/controls.jsx
@@ -39,7 +39,7 @@
and don't affect the query or backend data processing as those require to re run a query
and fetch the data. Note that if ALL controls in a seciton are set to "renderTrigger: true"
the section will appear in the "Customize" tab rather than the "Data" tab. You can add a
- "tabOverride" parameter to the controls section with a value of "data" or "customize" if
+ "tabOverride" parameter to the controls section with a value of "data" or "customize" if
you'd like to override this behavior either way
* - validators: an array of functions that will receive the value of the component and
should return error messages when the value is not valid. The error message gets
[superset] 01/03: simplifying tabOverride logic
Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch control-section-touchups
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 994b9c82e1f5af1e85cdfbd52a3f37f75c5a879a
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Sun Nov 15 20:35:33 2020 -0800
simplifying tabOverride logic
---
superset-frontend/src/explore/controlPanels/sections.tsx | 1 -
superset-frontend/src/explore/controls.jsx | 3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/explore/controlPanels/sections.tsx b/superset-frontend/src/explore/controlPanels/sections.tsx
index c86acbb..21d369e 100644
--- a/superset-frontend/src/explore/controlPanels/sections.tsx
+++ b/superset-frontend/src/explore/controlPanels/sections.tsx
@@ -101,7 +101,6 @@ export const annotations: ControlPanelSectionConfig = {
default: [],
description: 'Annotation layers',
renderTrigger: true,
- tabOverride: 'data',
},
},
],
diff --git a/superset-frontend/src/explore/controls.jsx b/superset-frontend/src/explore/controls.jsx
index 451ca52..22ae582 100644
--- a/superset-frontend/src/explore/controls.jsx
+++ b/superset-frontend/src/explore/controls.jsx
@@ -49,7 +49,8 @@
show a warning based on the value of another component. It's also possible to bind
arbitrary data from the redux store to the component this way.
* - tabOverride: set to 'data' if you want to force a renderTrigger to show up on the `Data`
- tab, otherwise `renderTrigger: true` components will show up on the `Style` tab.
+ tab, or 'customize' if you want it to show up on that tam. Otherwise sections with ALL
+ `renderTrigger: true` components will show up on the `Customize` tab.
*
* Note that the keys defined in controls in this file that are not listed above represent
* props specific for the React component defined as `type`. Also note that this module work