You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by re...@apache.org on 2024/04/03 10:45:30 UTC
(jackrabbit-oak) branch trunk updated: OAK-10708: error-level log failures to write the journal (#1363)
This is an automated email from the ASF dual-hosted git repository.
reschke pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5d163c8398 OAK-10708: error-level log failures to write the journal (#1363)
5d163c8398 is described below
commit 5d163c83989271fbcaebc6c36270a0aed64d992a
Author: Julian Reschke <re...@apache.org>
AuthorDate: Wed Apr 3 12:45:25 2024 +0200
OAK-10708: error-level log failures to write the journal (#1363)
* OAK-10708: error-level log failures to write the journal
* OAK-10708: also debug-level log the document
* OAK-10708: Update oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java
Co-authored-by: stefan-egli <st...@apache.org>
---------
Co-authored-by: stefan-egli <st...@apache.org>
---
.../java/org/apache/jackrabbit/oak/plugins/document/Commit.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java
index 66d6928d04..b3016219cd 100644
--- a/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java
+++ b/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java
@@ -352,7 +352,11 @@ public class Commit {
JournalEntry doc = JOURNAL.newDocument(store);
doc.modified(modifiedNodes);
Revision r = revision.asBranchRevision();
- store.create(JOURNAL, singletonList(doc.asUpdateOp(r)));
+ boolean success = store.create(JOURNAL, singletonList(doc.asUpdateOp(r)));
+ if (!success) {
+ LOG.error("Failed to update journal for revision {}", r);
+ LOG.debug("Failed to update journal for revision {} with doc {}", r, doc.format());
+ }
}
int commitRootDepth = commitRootPath.getDepth();