[GitHub] srowen commented on a change in pull request #23676: [SPARK-26754][PYTHON] Add hasTrainingSummary to replace duplicate code in PySpark

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23676: [SPARK-26754][PYTHON] Add hasTrainingSummary to replace duplicate code in PySpark
URL: https://github.com/apache/spark/pull/23676#discussion_r252909913
 
 

 ##########
 File path: python/pyspark/ml/clustering.py
 ##########
 @@ -141,7 +132,7 @@ def summary(self):
         training set. An exception is thrown if no summary exists.
 
 Review comment:
   I think you can then just eliminate these implementations, as they'll do just the same as the superclass. We lose the specialized doc comment, but, that's part of unifying these I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org