You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/11 08:26:17 UTC
[GitHub] [netbeans] hectorespert opened a new pull request #2443: Netbeans CI using Apache Jenkins infra
hectorespert opened a new pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert edited a comment on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert edited a comment on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-709421266
> hi @hectorespert you should discard old build maybe
> options {
> buildDiscarder(logRotator(numToKeepStr: '2'))
> }
`buildDiscarder` option added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-885802480
> @hectorespert that at the end is intended to replace GA and travis to check for PR ?
Yes, it was a try to start replacing GA and Travis due the limitations of these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-739242253
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-708347766
hi @hectorespert you should discard old build maybe
options {
buildDiscarder(logRotator(numToKeepStr: '2'))
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r505844330
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
I prefer to run ant tasks in stages for a better debug when it fails but I change the order to prevent run build task twice.
The other tasks doesn't depend to buid task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-708193315
> **Checks** seems to be confused, perhaps by all the force-pushes. Hard to follow what went on here.
Sorry, I've been testing some changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r505853177
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
Build task is required but is only executed in his step, the other tasks doesn't rerun any dependent target except bootstrap or init task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jglick commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
jglick commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-709465765
Despite often helping to maintain it, Ant is so rarely used these days that I totally forgot to suggest https://plugins.jenkins.io/ant/
```groovy
withAnt {
sh 'ant …'
}
```
which will improve display in the standard console log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert removed a comment on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert removed a comment on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-706729793
Jenkins, re test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jglick commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
jglick commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-885683598
Libraries are for sharing Pipeline script across projects. I would especially warn against loading a library from an implicit `master` branch as it means that pushes to another repo could cause builds to suddenly start breaking in this one, or conversely that PRs to this repo would fail until another repo was updated. Better to keep the Pipeline script here, so that for example a refactoring to `build.xml` to change Ant target names could simply make the corresponding change to `Jenkinsfile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r505844330
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
I prefer to run ant tasks in stages for a better debug when it fails ~~but I change the order to prevent run build task twice~~.
~~The other tasks doesn't depend to buid task.~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jglick commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
jglick commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r504642414
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
Remember that if you break up targets into `stage`s, you are potentially rerunning the same dependent targets and preventing Ant from using its dependency graph effectively. Generally recommend minimizing the total number of `sh` steps if possible: ideal to do the whole build in one line. At least compare times to see if that is contributing overhead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-891741931
@hectorespert, maybe for testing/adjusting you may use empty https://github.com/apache/netbeans-temp (@JaroslavTulach created it but maybe we can recycle ) and configure jenkins to see how it may scale behave on several parell PR / master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-709421266
> hi @hectorespert you should discard old build maybe
> options {
> buildDiscarder(logRotator(numToKeepStr: '2'))
> }
`buildDiscarder` added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r505844330
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
I prefer to run ant tasks in stages for a better debug when it fails ~~but I change the order to prevent run build task twice~~.
~~The other tasks doesn't depend to buid task. ~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-706729793
Jenkins, re test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-885743821
I see, on the particular case of netbeans I used it to avoid always copying pipeline modification because we build release branch to have javadoc menu updated on prior release (for forward navigation).
But for PR seems more tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-885678738
@hectorespert that at the end is intended to replace GA and travis to check for PR ?
I would suggest removing the content of the Jenkinsfile.groovy and make it call a new libraries (example here:
https://github.com/apache/netbeans/blob/master/nbbuild/jenkins/Jenkinsfile.groovy)
And you can add the real content here.
https://github.com/apache/netbeans-jenkins-lib/tree/master/vars
That may allow "independent" tweaking of the job and may save your time adjusting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#issuecomment-885809468
For PRs, if the Jenkins file is defined in project, it allows to adjust o improve the pipeline in an specific branch before merge it, like the travis.yaml config and GA config files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jglick commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
jglick commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r504641287
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
Oddly, seems that running sigtests takes _longer_ than commit validation. Seems like something is wrong there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r505853177
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
Build task is required but is only executed in his step, the other tasks doesn't rerun any task except bootstrap or init task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jglick commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
jglick commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r503617805
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk "JDK 1.8 (latest)"
+ ant "Ant (latest)"
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = "-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json"
+ }
+
+ stages {
+ stage("Check line endings") {
+ steps {
+ sh 'nbbuild/travis/check-line-endings.sh'
+ }
+ }
+
+ stage("Verify RAT report") {
+ steps {
+ sh 'ant rat'
+ }
+ }
+
+ stage("Verify libs and licenses") {
+ steps {
+ sh 'ant verify-libs-and-licenses'
+ }
+ }
+
+ stage("Linux build") {
+ steps {
+ sh "ant build"
+ }
+ }
+
+ stage("Verify sigtests") {
+ steps {
+ sh "ant check-sigtests-release"
+ }
+ }
+
+ stage("Commit validation") {
+ steps {
+ wrap([$class: 'Xvfb']) {
+ sh "ant commit-validation"
+ }
+ }
+ }
+
+ stage("Run harness unit tests") {
+ steps {
+ wrap([$class: 'Xvfb']) {
+ sh "ant test -Dtest.type=test-unit -Dtest.modules=harness/* -Dtest-unit-sys-prop.ignore.random.failures=true"
Review comment:
As a matter of course I would recommend using `'` rather than `"` which allows for Groovy string interpolation, which is unwanted for `sh` steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r504263125
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
Can't these run in parallel?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jglick commented on a change in pull request #2443: Netbeans CI using Apache Jenkins infra
Posted by GitBox <gi...@apache.org>.
jglick commented on a change in pull request #2443:
URL: https://github.com/apache/netbeans/pull/2443#discussion_r504270455
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
Review comment:
To be useful, that would require separate checkouts, and separate agents.
Since I presume `commit-validation` is by far the longest part, it would not buy you much to parallelize.
##########
File path: nbbuild/jenkins/github/Jenkinsfile.groovy
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent {
+ node {
+ label 'ubuntu'
+ }
+ }
+
+ tools {
+ jdk 'JDK 1.8 (latest)'
+ ant 'Ant (latest)'
+ }
+
+ triggers {
+ issueCommentTrigger('.*test this please.*')
+ }
+
+ environment {
+ ANT_OPTS = '-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json'
+ }
+
+ stages {
+ stage('Check line endings') {
+ steps {
+ sh 'nbbuild/travis/check-line-endings.sh'
+ }
+ }
+
+ stage('Verify RAT report') {
+ steps {
+ sh 'ant rat'
+ }
+ }
+
+ stage('Verify libs and licenses') {
+ steps {
+ sh 'ant verify-libs-and-licenses'
+ }
+ }
+
+ stage('Linux build') {
+ steps {
+ sh 'ant build'
+ }
+ }
+
+ stage('Verify sigtests') {
+ steps {
+ sh 'ant check-sigtests-release'
+ }
+ }
+
+ stage('Commit validation') {
+ steps {
+ wrap([$class: 'Xvfb']) {
+ sh 'ant commit-validation'
+ }
+ }
+ }
+ }
+
+ post {
+ always {
+ junit testResults: 'nbbuild/build/rat/*.xml,nbbuild/build/verifylibsandlicenses.xml,**/test/*/results/TEST*.xml,**/sigtest/check-release/*.xml', healthScaleFactor: 0.0
Review comment:
Why not
```suggestion
junit 'nbbuild/build/rat/*.xml,nbbuild/build/verifylibsandlicenses.xml,**/test/*/results/TEST*.xml,**/sigtest/check-release/*.xml'
```
? Are you deliberately suppressing test results or something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists