You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Fine0830 (via GitHub)" <gi...@apache.org> on 2023/02/14 09:42:40 UTC

[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #234: refactor: optimize the attached events visualization in the trace widget

Fine0830 opened a new pull request, #234:
URL: https://github.com/apache/skywalking-booster-ui/pull/234

   Optimize the attached events visualization in the trace widget.
   
   Signed-off-by: Qiuxia Fan <qi...@apache.org>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #234: refactor: optimize the attached events visualization in the trace widget

Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #234:
URL: https://github.com/apache/skywalking-booster-ui/pull/234#issuecomment-1430743283

   The events look like not ordering. These should be sorted by ascending. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #234: refactor: optimize the attached events visualization in the trace widget

Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #234:
URL: https://github.com/apache/skywalking-booster-ui/pull/234#issuecomment-1430775309

   Done
   
   <img width="1355" alt="1" src="https://user-images.githubusercontent.com/20871783/218940095-bd07b6bc-6847-42f8-a980-b42ff9e6866d.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #234: refactor: optimize the attached events visualization in the trace widget

Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #234:
URL: https://github.com/apache/skywalking-booster-ui/pull/234#issuecomment-1430748041

   > The events look like not ordering? These should be sorted by ascending.
   
   Sort data by event duration. Do you mean to sort data by "startTime"?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #234: refactor: optimize the attached events visualization in the trace widget

Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #234:
URL: https://github.com/apache/skywalking-booster-ui/pull/234#issuecomment-1430760823

   > Sort data by event duration. Do you mean to sort data by "startTime"?
   
   Yes. It should be sort by start time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-booster-ui] Fine0830 merged pull request #234: refactor: optimize the attached events visualization in the trace widget

Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 merged PR #234:
URL: https://github.com/apache/skywalking-booster-ui/pull/234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org