You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/01/31 10:06:22 UTC

[GitHub] rhtyd commented on a change in pull request #2433: Fix and enhance package script

rhtyd commented on a change in pull request #2433: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r165004778
 
 

 ##########
 File path: packaging/package.sh
 ##########
 @@ -67,22 +75,32 @@ function packaging() {
             exit 2
         fi
     fi
+
     VERSION=$(cd ../; $MVN org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep --color=none '^[0-9]\.')
+    BASEVER=$(echo "$VERSION" | sed 's/-SNAPSHOT//g')
 
 Review comment:
   -1 we would want to keep the SNAPSHOT in the package names.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services