You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/04 13:49:26 UTC
[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #436: fix: update instance dependency
Fine0830 opened a new pull request #436:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/436
Reference https://github.com/apache/skywalking/issues/6490
Screenshot
Signed-off-by: Qiuxia Fan <qi...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #436: fix: update instance dependency
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #436:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/436#discussion_r587997457
##########
File path: src/store/modules/topology/index.ts
##########
@@ -643,10 +643,15 @@ const actions: ActionTree<State, any> = {
for (const call of topoCalls) {
if (call.detectPoints.includes('CLIENT')) {
clientIdsC.push(call.id);
- } else {
+ }
+ if (call.detectPoints.includes('SERVER')) {
serverIdsC.push(call.id);
}
}
+ if (!serverIdsC.length || !clientIdsC.length) {
Review comment:
> Should use `&&`
Here I need to change the logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #436: fix: update instance dependency
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #436:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/436#issuecomment-791151302
Please recheck @wu-sheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on a change in pull request #436: fix: update instance dependency
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #436:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/436#discussion_r587503176
##########
File path: src/store/modules/topology/index.ts
##########
@@ -643,10 +643,15 @@ const actions: ActionTree<State, any> = {
for (const call of topoCalls) {
if (call.detectPoints.includes('CLIENT')) {
clientIdsC.push(call.id);
- } else {
+ }
+ if (call.detectPoints.includes('SERVER')) {
serverIdsC.push(call.id);
}
}
+ if (!serverIdsC.length || !clientIdsC.length) {
Review comment:
```suggestion
if (!serverIdsC.length && !clientIdsC.length) {
```
Should use `&&`? And will you build request by the matrix of `serverIdsC` and `clientIdsC`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #436: fix: update instance dependency
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #436:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/436#discussion_r587997270
##########
File path: src/store/modules/topology/index.ts
##########
@@ -643,10 +643,15 @@ const actions: ActionTree<State, any> = {
for (const call of topoCalls) {
if (call.detectPoints.includes('CLIENT')) {
clientIdsC.push(call.id);
- } else {
+ }
+ if (call.detectPoints.includes('SERVER')) {
serverIdsC.push(call.id);
}
}
+ if (!serverIdsC.length || !clientIdsC.length) {
Review comment:
> And will you build request by the matrix of `serverIdsC` and `clientIdsC`?
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #436: fix: update instance dependency
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #436:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org