You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/13 08:47:44 UTC
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3025: [Feature][Log] Integrate slf4j and log4j2 for unified management logs
hailin0 commented on code in PR #3025:
URL: https://github.com/apache/incubator-seatunnel/pull/3025#discussion_r994346633
##########
seatunnel-core/seatunnel-starter/pom.xml:
##########
@@ -52,10 +52,44 @@
<artifactId>seatunnel-engine-server</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <!-- Declare log4j2 asynchronous loggers provider: disruptor -->
+ <dependency>
+ <groupId>com.lmax</groupId>
+ <artifactId>disruptor</artifactId>
+ </dependency>
+
</dependencies>
<build>
<finalName>${project.name}</finalName>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <configuration>
+ <artifactSet>
+ <excludes>
+ <!-- not excluded: slf4j-api & log4j2 & xxx-to-slf4j bridges -->
+ <exclude>org.slf4j:slf4j-jdk14</exclude>
+ <exclude>org.slf4j:slf4j-nop</exclude>
+ <exclude>org.slf4j:slf4j-simple</exclude>
+ <exclude>org.slf4j:slf4j-reload4j</exclude>
+ <exclude>org.slf4j:slf4j-log4j12</exclude>
+ <exclude>log4j:*</exclude>
+ <exclude>commons-logging:*</exclude>
+ <exclude>ch.qos.logback:*</exclude>
+ <exclude>org.apache.logging.log4j:log4j-to-slf4j</exclude>
+ </excludes>
+ </artifactSet>
+ </configuration>
+ </plugin>
+ <!-- make sure that flatten runs after maven-shade-plugin -->
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>flatten-maven-plugin</artifactId>
+ </plugin>
Review Comment:
Do I need to delete?
@ashulin
https://github.com/apache/incubator-seatunnel/pull/3078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org