You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/07/15 17:25:25 UTC

[GitHub] spark pull request #21505: [SPARK-24457][SQL] Improving performance of strin...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21505#discussion_r202548671
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/StringToTimestampBenchmark.scala ---
    @@ -0,0 +1,53 @@
    +/*
    --- End diff --
    
    Does this really need to go in the code base?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org