You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by witgo <gi...@git.apache.org> on 2014/12/24 09:00:47 UTC
[GitHub] spark pull request: [SPARK-4952][Core]Handle ConcurrentModificatio...
GitHub user witgo opened a pull request:
https://github.com/apache/spark/pull/3788
[SPARK-4952][Core]Handle ConcurrentModificationExceptions in SparkEnv.environmentDetails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/witgo/spark SPARK-4952
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3788
----
commit d903529819f090288f6acfb666873f9ac01990be
Author: GuoQiang Li <wi...@qq.com>
Date: 2014-12-24T07:56:59Z
Handle ConcurrentModificationExceptions in SparkEnv.environmentDetails
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4952][Core]Handle ConcurrentModificatio...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3788#issuecomment-68039346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24778/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4952][Core]Handle ConcurrentModificatio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4952][Core]Handle ConcurrentModificatio...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3788#discussion_r22249654
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -395,7 +395,7 @@ object SparkEnv extends Logging {
val sparkProperties = (conf.getAll ++ schedulerMode).sorted
// System properties that are not java classpaths
- val systemProperties = System.getProperties.iterator.toSeq
+ val systemProperties = Utils.getSystemProperties.toSeq
--- End diff --
It wasn't clear to me at first whether this is the culprit, but it looks so since the underlying object being modified is a `java.util.Properties`. The defensive copy made in `Utils` should be thread-safe in the sense that `Hashtable.clone()` is `synchronized`. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4952][Core]Handle ConcurrentModificatio...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3788#issuecomment-68171484
Thanks for this patch and @srowen for the review! I'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4952][Core]Handle ConcurrentModificatio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3788#issuecomment-68034841
[Test build #24778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24778/consoleFull) for PR 3788 at commit [`d903529`](https://github.com/apache/spark/commit/d903529819f090288f6acfb666873f9ac01990be).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4952][Core]Handle ConcurrentModificatio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3788#issuecomment-68039339
[Test build #24778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24778/consoleFull) for PR 3788 at commit [`d903529`](https://github.com/apache/spark/commit/d903529819f090288f6acfb666873f9ac01990be).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org