You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2016/05/31 17:28:33 UTC

[GitHub] flink pull request: [hotfix] Fix JSONDeserializationSchema for Kafka; Parame...

GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/2057

    [hotfix] Fix JSONDeserializationSchema for Kafka; ParameterTool usability

    The JSONDeserializationSchema was implementing the KeyedDeserializationSchema. However, it was not using the key or any other additional metadata.
    Therefore, I changed the base class.
    
    Also, the `ParameterTool`'s exception for reading a `.properties` file has been improved.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink mini-hotfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2057
    
----
commit 6f334b81fd17d80a46d62797e918a098406cf6a0
Author: Robert Metzger <rm...@apache.org>
Date:   2016-05-31T16:50:35Z

    [hotfix] Fix JSONDeserializationSchema for Kafka; ParameterTool usability

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2057: [hotfix] Fix JSONDeserializationSchema for Kafka; Paramet...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2057
  
    Thanks for the review. I'll split and merge the commits


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [hotfix] Fix JSONDeserializationSchema for Kafka; Parame...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/2057
  
    Please move the change to the parameter tool exception into a separate commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2057: [hotfix] Fix JSONDeserializationSchema for Kafka; ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2057


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---