You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/11 05:38:00 UTC
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request
#329: HDDS-2423. Add the recover-trash command client side code
xiaoyuyao commented on a change in pull request #329: HDDS-2423. Add the recover-trash command client side code
URL: https://github.com/apache/hadoop-ozone/pull/329#discussion_r356410831
##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -720,6 +720,14 @@ public void renameKey(String volumeName, String bucketName,
keyPrefix, maxKeys);
}
+ @Override
+ public boolean recoverTrash(String volumeName, String bucketName,
+ String keyName, String destinationName) throws IOException {
Review comment:
NIT: can we rename destinationName to destinationBucket to be consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org