You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by SreeramGarlapati <gi...@git.apache.org> on 2017/06/02 00:15:41 UTC
[GitHub] nifi pull request #1880: NIFI-4007 Update azure EventHubs client to latest v...
GitHub user SreeramGarlapati opened a pull request:
https://github.com/apache/nifi/pull/1880
NIFI-4007 Update azure EventHubs client to latest version
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [y ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ y] Have you written or updated unit tests to verify your changes?
- [ y] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ y] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ y] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ y] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ y] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
Couple of azure eventhubs customers using apache-nifi-processor are running into known issues fixed in later versions. So updating the version to the latest - for the next release to pick this up.
https://issues.apache.org/jira/browse/NIFI-4007
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SreeramGarlapati/nifi sg.updateEventHubVersion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1880
----
commit c6425baa60e5d5178e0668c4fa152c2cd28f7459
Author: Sreeram Garlapati <sr...@sree.guest.corp.microsoft.com>
Date: 2017-06-01T23:34:55Z
Update azure EventHubs client to latest version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1880: NIFI-4007 Update azure EventHubs client to latest version
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1880
Also, right now, 0.14.2 is available, I'd suggest to go with this version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1880: NIFI-4007 Update azure EventHubs client to latest v...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1880: NIFI-4007 Update azure EventHubs client to latest version
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1880
Hi @SreeramGarlapati, thanks for your contribution. I looked at the release notes from
https://github.com/Azure/azure-event-hubs-java/
And it seems there are few breaking changes between 0.9.0 and 0.14.0.
In particular:
- The ``EventData.ApplicationProperties`` is now a ``Map<String, object>``.
- Simplified EventData by deprecating the ``getBody*`` API's. As such, the following methods have been deprecated (#81):
``EventData.getBody()`` replaced with ``EventData.getBytes()``
``EventData.getBodyOffset()``
``EventData.getBodyLength()``
I think we are only concerned by the deprecation of the ``getBody()`` that should be replaced by ``getBytes()`` in ``GetAzureEventHub``. Could you take care of that?
Otherwise, I did few tests and it seems to be working as expected.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1880: NIFI-4007 Update azure EventHubs client to latest version
Posted by SreeramGarlapati <gi...@git.apache.org>.
Github user SreeramGarlapati commented on the issue:
https://github.com/apache/nifi/pull/1880
@pvillard31 - appreciate your feedback...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1880: NIFI-4007 Update azure EventHubs client to latest version
Posted by SreeramGarlapati <gi...@git.apache.org>.
Github user SreeramGarlapati commented on the issue:
https://github.com/apache/nifi/pull/1880
Hello Folks! can someone please help with the next steps...
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1880: NIFI-4007 Update azure EventHubs client to latest version
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1880
+1, merging, thanks @SreeramGarlapati
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---