[GitHub] [nifi] davidvoit commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method

[GitBox <gi...@apache.org>]

davidvoit commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method
URL: https://github.com/apache/nifi/pull/4034#discussion_r374936740
 
 

 ##########
 File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
 ##########
 @@ -128,7 +128,7 @@ protected Record createRecord(final ResultSet rs) throws SQLException {
     }
 
     @SuppressWarnings("rawtypes")
-    private Object normalizeValue(final Object value) {
+    private Object normalizeValue(final Object value) throws SQLException {
 
 Review comment:
   The getArray() call is throwing this, so yes we need to rethrow the error or try catch it.
   As createRecord is already handling this, and createrecord is the only place where normalizeValue is called, this looks correct to me. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services