You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Havard <br...@kheldar.apana.org.au> on 2001/07/21 09:11:30 UTC

Re: cvs commit: httpd-2.0/server Makefile.in

On 21 Jul 2001 06:34:55 -0000, rbb@apache.org wrote:

>rbb         01/07/20 23:34:55
>
>  Modified:    .        CHANGES
>               server   Makefile.in
>  Added:       build    make_exports.awk
>  Log:
>  Improve the exports generating awk script.  In the past, we had
>  work around problems in the awk script by avoiding some #if and
>  #ifdefs.  This has bitten us many times in generating the exports.c
>  file.  This improvement allows corrects the header file parsing.

This now misses a few things, especially most of the macro generated hooks:

F:\Apache\httpd-2.0\server>grep ap_hook_ exports.c.old | wc -l
     44

F:\Apache\httpd-2.0\server>grep ap_run_ exports.c.old | wc -l
     24

F:\Apache\httpd-2.0\server>grep ap_hook_ exports.c | wc -l
      0

F:\Apache\httpd-2.0\server>grep ap_run_ exports.c | wc -l
      2

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


RE: cvs commit: httpd-2.0/server Makefile.in

Posted by Sander Striker <st...@apache.org>.
> On Sat, 21 Jul 2001 11:52:59 +0200, Sander Striker wrote:
> 
> >Brain Harvard wrote: 
> 
> Err, could you have misspelt my name any worse? (no, that's not an
> invitation to try :)

Sorry Brain. The human mind has a strange way of seeing things
that are not there.

Sander


RE: cvs commit: httpd-2.0/server Makefile.in

Posted by Brian Havard <br...@kheldar.apana.org.au>.
On Sat, 21 Jul 2001 11:52:59 +0200, Sander Striker wrote:

>Brain Harvard wrote: 

Err, could you have misspelt my name any worse? (no, that's not an
invitation to try :)


>> This now misses a few things, especially most of the macro 
>> generated hooks:
>> 
>> F:\Apache\httpd-2.0\server>grep ap_hook_ exports.c.old | wc -l
>>      44
>> 
>> F:\Apache\httpd-2.0\server>grep ap_run_ exports.c.old | wc -l
>>      24
>> 
>> F:\Apache\httpd-2.0\server>grep ap_hook_ exports.c | wc -l
>>       0
>> 
>> F:\Apache\httpd-2.0\server>grep ap_run_ exports.c | wc -l
>>       2
>
>Whoops. Sorry about that. I missed the AP_HOOK_ stuff...
>I'll submit a patch shortly.

Tried it, looks good. I'll commit it in a moment.

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


RE: cvs commit: httpd-2.0/server Makefile.in

Posted by Sander Striker <st...@apache.org>.
[...]
>>  Log:
>>  Improve the exports generating awk script.  In the past, we had
>>  work around problems in the awk script by avoiding some #if and
>>  #ifdefs.  This has bitten us many times in generating the exports.c
>>  file.  This improvement allows corrects the header file parsing.

Brain Harvard wrote: 
> This now misses a few things, especially most of the macro 
> generated hooks:
> 
> F:\Apache\httpd-2.0\server>grep ap_hook_ exports.c.old | wc -l
>      44
> 
> F:\Apache\httpd-2.0\server>grep ap_run_ exports.c.old | wc -l
>      24
> 
> F:\Apache\httpd-2.0\server>grep ap_hook_ exports.c | wc -l
>       0
> 
> F:\Apache\httpd-2.0\server>grep ap_run_ exports.c | wc -l
>       2

Whoops. Sorry about that. I missed the AP_HOOK_ stuff...
I'll submit a patch shortly.

Sander