You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Stephane Bailliez (JIRA)" <ji...@apache.org> on 2007/11/22 12:32:43 UTC

[jira] Created: (WICKET-1179) Javadoc for IConverter need to be more clear regarding nullable arguments

Javadoc for IConverter need to be more clear regarding nullable arguments
-------------------------------------------------------------------------

                 Key: WICKET-1179
                 URL: https://issues.apache.org/jira/browse/WICKET-1179
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.0-rc1
            Reporter: Stephane Bailliez


The javadoc of the IConverter does not mention the possibility of the arguments being null or not.

They obviously can be but we can find a lot of different logic in the different converters regarding if the value is null or empty string or if the locale is null or not, this should help bring more consistency in the implementation if the interface mentions clearly what is supposed to receive. 

I could question whether each converter need to handle the fact we could have a null Locale, surely the caller can have this default locale set so that we can assert that Locale is never null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1179) Javadoc for IConverter need to be more clear regarding nullable arguments

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1179.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0-rc3
         Assignee: Igor Vaynberg

> Javadoc for IConverter need to be more clear regarding nullable arguments
> -------------------------------------------------------------------------
>
>                 Key: WICKET-1179
>                 URL: https://issues.apache.org/jira/browse/WICKET-1179
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Stephane Bailliez
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.0-rc3
>
>
> The javadoc of the IConverter does not mention the possibility of the arguments being null or not.
> They obviously can be but we can find a lot of different logic in the different converters regarding if the value is null or empty string or if the locale is null or not, this should help bring more consistency in the implementation if the interface mentions clearly what is supposed to receive. 
> I could question whether each converter need to handle the fact we could have a null Locale, surely the caller can have this default locale set so that we can assert that Locale is never null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1179) Javadoc for IConverter need to be more clear regarding nullable arguments

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1179:
---------------------------------------

    Fix Version/s:     (was: 1.3.0-rc3)
                   1.3.0-final

> Javadoc for IConverter need to be more clear regarding nullable arguments
> -------------------------------------------------------------------------
>
>                 Key: WICKET-1179
>                 URL: https://issues.apache.org/jira/browse/WICKET-1179
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Stephane Bailliez
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.0-final
>
>
> The javadoc of the IConverter does not mention the possibility of the arguments being null or not.
> They obviously can be but we can find a lot of different logic in the different converters regarding if the value is null or empty string or if the locale is null or not, this should help bring more consistency in the implementation if the interface mentions clearly what is supposed to receive. 
> I could question whether each converter need to handle the fact we could have a null Locale, surely the caller can have this default locale set so that we can assert that Locale is never null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.