You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/02 09:27:01 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3944: vpc/server: Fix network statistics for vpc
ustcweizhou opened a new pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944
# Description
<!--- Describe your changes in detail -->
This contains 3 main changes
(1) add NETWORK_STATS_ethX for all nics with public ips in VPC VRs (current: NETWORK_STATS_eth1)
(2) DO NOT create records in user_statistics for each VPC tier (only one record per public nic per VPC VR)
(3) send NetworkUsageCommand before unplugging a NIC with public IPs from VPC VR
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643066450
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-784429667
<b>Trillian test result (tid-3601)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31877 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3944-t3601-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652933438
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-682421741
@weizhouapache @ustcweizhou can you start a discussion thread on dev ML? This needs some discussion before we can consider merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652897721
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-805609081
> @rhtyd @weizhouapache no discussion has happened, do we dare merge this?
@DaanHoogland @rhtyd
it is ok for me to merge it :-D
we have this patch on our productions. looks good until now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-653813589
<b>Trillian test result (tid-1976)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49953 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3944-t1976-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1807.31 | test_kubernetes_supported_versions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-784031047
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783665400
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2796
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652926337
Packaging result: ✔centos7 ✔debian. JID-1508
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-740543043
@ustcweizhou @weizhouapache can you comment/explore the cases where this could add regression for usage/billing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783473497
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-785006167
@rhtyd @weizhouapache no discussion has happened, do we dare merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643078554
Packaging result: ✔centos7 ✔debian. JID-1356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-740626793
@DaanHoogland @rhtyd
this fixes bugs in network statistics for vpc.
cloudstack should collect network statistics from the public interfaces, not from eth1 which is default public nic for vpc but there might be more public nics, not from vpc tiers.
in a word, there is not per tier billing. there are only statistics for all public interfaces in VR for isolated network and vpc, and for all nics on shared network.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-653723883
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643537494
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783257413
@weizhouapache conflicts here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-784031765
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-741789787
@weizhouapache the changes seem logical to me and given your description above seem to do what you intended, but we have no testdescription and no integration tests to guarantee against regressions. I'm a bit reluctant to include this just before release. can we with just the current set of smoke tests? cc @rhtyd @sureshanaparti are there any others we could ask for testing this functionality?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-729130098
@weizhouapache converted to draft so it is clear 4.15 is not waiting for it. please change back if you disagree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783474536
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643538661
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-653723985
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652933874
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783519732
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783935123
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-742026177
> @weizhouapache the changes seem logical to me and given your description above seem to do what you intended, but we have no testdescription and no integration tests to guarantee against regressions. I'm a bit reluctant to include this just before release. can we with just the current set of smoke tests? cc @rhtyd @sureshanaparti are there any others we could ask for testing this functionality?
@DaanHoogland let's move this to 4.15.1.0 (and 4.14.1.0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643550937
Packaging result: ✖centos7 ✖debian. JID-1368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-643066318
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-783519732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #3944:
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-652897077
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org