You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/01/31 17:28:56 UTC
[GitHub] brooklyn-dist pull request #82: Avoid sshd.core bundle rewiring on startup
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-dist/pull/82
Avoid sshd.core bundle rewiring on startup
This builds on Svet's https://github.com/apache/brooklyn-dist/pull/48 (so should be rebased once that is merged first).
It avoids the rewiring of the bundle org.apache.sshd.core, which would otherwise happen when bouncycastle bundles were later installed.
I've been testing it with https://github.com/apache/brooklyn-server/pull/547.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-dist fix-cxf-version-strike2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit 490085b24f013ad78400cacc39653ac8dcfbf438
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2016-09-20T11:34:44Z
Upgrade to Karaf 4.0.6
Reorders loading order - rest-resources after karaf-init as it depends on the ManagementContext service
commit 346d2715f33214e444d11465f1589bba018566ee
Author: Aled Sage <al...@gmail.com>
Date: 2017-01-31T16:45:52Z
karaf: add bouncycastle early (avoid sshd rewiring)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #82: Avoid sshd.core bundle rewiring on startup
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #82: Avoid sshd.core bundle rewiring on startup
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-dist/pull/82
@aledsage can you close, merged in https://github.com/apache/brooklyn-dist/pull/83.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #82: Avoid sshd.core bundle rewiring on startup
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/82#discussion_r99374917
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -43,6 +43,10 @@
<feature>package</feature>
<feature>service</feature>
<feature>system</feature>
+
+ <!-- org.apache.sshd.core/0.14.0 refreshes otherwise, when bcprov-ext and/or bcpkiv 1.51.0 is added -->
+ <bundle dependency="true">mvn:org.bouncycastle/bcprov-ext-jdk15on/${bouncycastle.version}</bundle>
+ <bundle dependency="true">mvn:org.bouncycastle/bcpkix-jdk15on/${bouncycastle.version}</bundle>
--- End diff --
Do we need both of these?
Can you also remove [this config](https://github.com/apache/brooklyn-dist/blob/master/karaf/apache-brooklyn/src/main/resources/etc/system.properties#L135-L142) as it's no longer needed with the new bouncycastle version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #82: Avoid sshd.core bundle rewiring on startup
Posted by googlielmo <gi...@git.apache.org>.
Github user googlielmo commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/82#discussion_r99377618
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -43,6 +43,10 @@
<feature>package</feature>
<feature>service</feature>
<feature>system</feature>
+
+ <!-- org.apache.sshd.core/0.14.0 refreshes otherwise, when bcprov-ext and/or bcpkiv 1.51.0 is added -->
+ <bundle dependency="true">mvn:org.bouncycastle/bcprov-ext-jdk15on/${bouncycastle.version}</bundle>
+ <bundle dependency="true">mvn:org.bouncycastle/bcpkix-jdk15on/${bouncycastle.version}</bundle>
--- End diff --
@neykov yes we need both, I tried all combinations :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #82: Avoid sshd.core bundle rewiring on startup
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/82
@googlielmo @neykov thanks; I've changed this PR so it only modifies the comment explaining why we're including BouncyCastle (I think it's very useful to know that it causes the refresh of the sshd bundle - otherwise we end up with weird stuff in our feature.xml with a comment about "avoiding refreshing", without it being clear why each is needed.
Merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #82: Avoid sshd.core bundle rewiring on startup
Posted by googlielmo <gi...@git.apache.org>.
Github user googlielmo commented on the issue:
https://github.com/apache/brooklyn-dist/pull/82
@neykov I removed the config in #83 (sorry for the duplicate PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---