You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/12/01 03:47:12 UTC
Review Request 40810: AMBARI-14121. Express Upgrade authors configs as
_anonymous instead of auth user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
Bugs: AMBARI-14121
https://issues.apache.org/jira/browse/AMBARI-14121
Repository: ambari
Description
-------
When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
Diff: https://reviews.apache.org/r/40810/diff/
Testing
-------
Waiting for unit test results.
Verified during an Express Upgrade from HDP 2.2 to 2.3
```
ambari=> select service_name, version, user_name from serviceconfig;
service_name | version | user_name
--------------+---------+-----------
HDFS | 1 | admin
ZOOKEEPER | 1 | admin
MAPREDUCE2 | 1 | admin
YARN | 1 | admin
ZOOKEEPER | 2 | admin
MAPREDUCE2 | 2 | admin
HDFS | 2 | admin
YARN | 2 | admin
```
Thanks,
Alejandro Fernandez
Re: Review Request 40810: AMBARI-14121. Express Upgrade authors
configs as _anonymous instead of auth user
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/#review108472
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java (line 112)
<https://reviews.apache.org/r/40810/#comment167930>
Maybe add better logging for fallback?
- Dmitro Lisnichenko
On Dec. 1, 2015, 4:48 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40810/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 4:48 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-14121
> https://issues.apache.org/jira/browse/AMBARI-14121
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
>
> This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
>
> Diff: https://reviews.apache.org/r/40810/diff/
>
>
> Testing
> -------
>
> Waiting for unit test results.
> Ran manually for UpgradeResourceProviderTest.java and it passed.
>
> Verified during an Express Upgrade from HDP 2.2 to 2.3
> ```
> ambari=> select service_name, version, user_name from serviceconfig;
> service_name | version | user_name
> --------------+---------+-----------
> HDFS | 1 | admin
> ZOOKEEPER | 1 | admin
> MAPREDUCE2 | 1 | admin
> YARN | 1 | admin
> ZOOKEEPER | 2 | admin
> MAPREDUCE2 | 2 | admin
> HDFS | 2 | admin
> YARN | 2 | admin
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40810: AMBARI-14121. Express Upgrade authors
configs as _anonymous instead of auth user
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/#review108522
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 30, 2015, 9:48 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40810/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 9:48 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-14121
> https://issues.apache.org/jira/browse/AMBARI-14121
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
>
> This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
>
> Diff: https://reviews.apache.org/r/40810/diff/
>
>
> Testing
> -------
>
> Waiting for unit test results.
> Ran manually for UpgradeResourceProviderTest.java and it passed.
>
> Verified during an Express Upgrade from HDP 2.2 to 2.3
> ```
> ambari=> select service_name, version, user_name from serviceconfig;
> service_name | version | user_name
> --------------+---------+-----------
> HDFS | 1 | admin
> ZOOKEEPER | 1 | admin
> MAPREDUCE2 | 1 | admin
> YARN | 1 | admin
> ZOOKEEPER | 2 | admin
> MAPREDUCE2 | 2 | admin
> HDFS | 2 | admin
> YARN | 2 | admin
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40810: AMBARI-14121. Express Upgrade authors
configs as _anonymous instead of auth user
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/#review108626
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 2, 2015, 2:17 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40810/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 2:17 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-14121
> https://issues.apache.org/jira/browse/AMBARI-14121
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
>
> This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3bf6cad
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 38370c7
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 6a2986e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40810/diff/
>
>
> Testing
> -------
>
> Waiting for unit test results.
> Ran manually for UpgradeResourceProviderTest.java and it passed.
>
> Verified during an Express Upgrade from HDP 2.2 to 2.3
> ```
> ambari=> select service_name, version, user_name from serviceconfig;
> service_name | version | user_name
> --------------+---------+-----------
> HDFS | 1 | admin
> ZOOKEEPER | 1 | admin
> MAPREDUCE2 | 1 | admin
> YARN | 1 | admin
> ZOOKEEPER | 2 | admin
> MAPREDUCE2 | 2 | admin
> HDFS | 2 | admin
> YARN | 2 | admin
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40810: AMBARI-14121. Express Upgrade authors
configs as _anonymous instead of auth user
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/#review108636
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Dec. 1, 2015, 7:17 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40810/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 7:17 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-14121
> https://issues.apache.org/jira/browse/AMBARI-14121
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
>
> This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3bf6cad
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 38370c7
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 6a2986e
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40810/diff/
>
>
> Testing
> -------
>
> Waiting for unit test results.
> Ran manually for UpgradeResourceProviderTest.java and it passed.
>
> Verified during an Express Upgrade from HDP 2.2 to 2.3
> ```
> ambari=> select service_name, version, user_name from serviceconfig;
> service_name | version | user_name
> --------------+---------+-----------
> HDFS | 1 | admin
> ZOOKEEPER | 1 | admin
> MAPREDUCE2 | 1 | admin
> YARN | 1 | admin
> ZOOKEEPER | 2 | admin
> MAPREDUCE2 | 2 | admin
> HDFS | 2 | admin
> YARN | 2 | admin
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40810: AMBARI-14121. Express Upgrade authors
configs as _anonymous instead of auth user
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 12:17 a.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
Bugs: AMBARI-14121
https://issues.apache.org/jira/browse/AMBARI-14121
Repository: ambari
Description
-------
When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3bf6cad
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 38370c7
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 6a2986e
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml PRE-CREATION
Diff: https://reviews.apache.org/r/40810/diff/
Testing
-------
Waiting for unit test results.
Ran manually for UpgradeResourceProviderTest.java and it passed.
Verified during an Express Upgrade from HDP 2.2 to 2.3
```
ambari=> select service_name, version, user_name from serviceconfig;
service_name | version | user_name
--------------+---------+-----------
HDFS | 1 | admin
ZOOKEEPER | 1 | admin
MAPREDUCE2 | 1 | admin
YARN | 1 | admin
ZOOKEEPER | 2 | admin
MAPREDUCE2 | 2 | admin
HDFS | 2 | admin
YARN | 2 | admin
```
Thanks,
Alejandro Fernandez
Re: Review Request 40810: AMBARI-14121. Express Upgrade authors
configs as _anonymous instead of auth user
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/
-----------------------------------------------------------
(Updated Dec. 1, 2015, 10:53 p.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
Changes
-------
Added logging and unit test.
Bugs: AMBARI-14121
https://issues.apache.org/jira/browse/AMBARI-14121
Repository: ambari
Description
-------
When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 38370c7
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 6a2986e
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml PRE-CREATION
Diff: https://reviews.apache.org/r/40810/diff/
Testing
-------
Waiting for unit test results.
Ran manually for UpgradeResourceProviderTest.java and it passed.
Verified during an Express Upgrade from HDP 2.2 to 2.3
```
ambari=> select service_name, version, user_name from serviceconfig;
service_name | version | user_name
--------------+---------+-----------
HDFS | 1 | admin
ZOOKEEPER | 1 | admin
MAPREDUCE2 | 1 | admin
YARN | 1 | admin
ZOOKEEPER | 2 | admin
MAPREDUCE2 | 2 | admin
HDFS | 2 | admin
YARN | 2 | admin
```
Thanks,
Alejandro Fernandez
Re: Review Request 40810: AMBARI-14121. Express Upgrade authors
configs as _anonymous instead of auth user
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/#review108458
-----------------------------------------------------------
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java (line 1024)
<https://reviews.apache.org/r/40810/#comment167914>
Should we add some test to check, if the username was set correctly?
- Dmytro Grinenko
On Dec. 1, 2015, 2:48 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40810/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 2:48 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-14121
> https://issues.apache.org/jira/browse/AMBARI-14121
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
>
> This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
>
> Diff: https://reviews.apache.org/r/40810/diff/
>
>
> Testing
> -------
>
> Waiting for unit test results.
> Ran manually for UpgradeResourceProviderTest.java and it passed.
>
> Verified during an Express Upgrade from HDP 2.2 to 2.3
> ```
> ambari=> select service_name, version, user_name from serviceconfig;
> service_name | version | user_name
> --------------+---------+-----------
> HDFS | 1 | admin
> ZOOKEEPER | 1 | admin
> MAPREDUCE2 | 1 | admin
> YARN | 1 | admin
> ZOOKEEPER | 2 | admin
> MAPREDUCE2 | 2 | admin
> HDFS | 2 | admin
> YARN | 2 | admin
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40810: AMBARI-14121. Express Upgrade authors
configs as _anonymous instead of auth user
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/
-----------------------------------------------------------
(Updated Dec. 1, 2015, 2:48 a.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
Bugs: AMBARI-14121
https://issues.apache.org/jira/browse/AMBARI-14121
Repository: ambari
Description
-------
When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user.
This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd
Diff: https://reviews.apache.org/r/40810/diff/
Testing (updated)
-------
Waiting for unit test results.
Ran manually for UpgradeResourceProviderTest.java and it passed.
Verified during an Express Upgrade from HDP 2.2 to 2.3
```
ambari=> select service_name, version, user_name from serviceconfig;
service_name | version | user_name
--------------+---------+-----------
HDFS | 1 | admin
ZOOKEEPER | 1 | admin
MAPREDUCE2 | 1 | admin
YARN | 1 | admin
ZOOKEEPER | 2 | admin
MAPREDUCE2 | 2 | admin
HDFS | 2 | admin
YARN | 2 | admin
```
Thanks,
Alejandro Fernandez