You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Phil Steitz (JIRA)" <ji...@apache.org> on 2011/02/05 03:57:30 UTC
[jira] Commented: (MATH-506) The static field
ChiSquareTestImpl.distribution serves no purpose
[ https://issues.apache.org/jira/browse/MATH-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990893#comment-12990893 ]
Phil Steitz commented on MATH-506:
----------------------------------
Agreed. Since the fix for MATH-349 this instance field is unnecessary.
> The static field ChiSquareTestImpl.distribution serves no purpose
> -----------------------------------------------------------------
>
> Key: MATH-506
> URL: https://issues.apache.org/jira/browse/MATH-506
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.1, 3.0
> Reporter: Sebb
> Priority: Minor
>
> The static field ChiSquareTestImpl.distribution serves no purpose.
> There is a setter for it, but in every case where the field is used, it is first overwritten with a new value.
> The field and the setter should be removed, and the methods that create a new instance should create a local variable instead.
> For Math 2.1, the field can be removed and the setter deprecated.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira