You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/26 12:03:25 UTC
[GitHub] [incubator-nuttx] chengkai15 opened a new pull request, #6935: arch/sim: add bth4 bridge codes
chengkai15 opened a new pull request, #6935:
URL: https://github.com/apache/incubator-nuttx/pull/6935
Signed-off-by: chengkai <ch...@xiaomi.com>
## Summary
add sim bt bridge register
## Impact
NO
## Testing
ci pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6935: arch/sim: add bth4 bridge codes
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6935:
URL: https://github.com/apache/incubator-nuttx/pull/6935#discussion_r956608773
##########
drivers/wireless/bluetooth/bt_bridge.c:
##########
@@ -69,7 +69,7 @@ struct bt_bridge_s
#ifdef CONFIG_BLUETOOTH_BRIDGE_BTSNOOP
FAR struct snoop_s *snoop;
#endif /* CONFIG_BLUETOOTH_BRIDGE_BTSNOOP */
- uint8_t refs;
+ atomic_uint refs;
Review Comment:
Let me take a closer look on Monday
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6935: arch/sim: add bth4 bridge codes
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6935:
URL: https://github.com/apache/incubator-nuttx/pull/6935#discussion_r956593438
##########
drivers/wireless/bluetooth/bt_bridge.c:
##########
@@ -69,7 +69,7 @@ struct bt_bridge_s
#ifdef CONFIG_BLUETOOTH_BRIDGE_BTSNOOP
FAR struct snoop_s *snoop;
#endif /* CONFIG_BLUETOOTH_BRIDGE_BTSNOOP */
- uint8_t refs;
+ atomic_uint refs;
Review Comment:
Do we need any dependency on atomic config?or atomic_uint is supported unconditionally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6935: arch/sim: add bth4 bridge codes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6935:
URL: https://github.com/apache/incubator-nuttx/pull/6935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6935: arch/sim: add bth4 bridge codes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6935:
URL: https://github.com/apache/incubator-nuttx/pull/6935#discussion_r956594682
##########
drivers/wireless/bluetooth/bt_bridge.c:
##########
@@ -69,7 +69,7 @@ struct bt_bridge_s
#ifdef CONFIG_BLUETOOTH_BRIDGE_BTSNOOP
FAR struct snoop_s *snoop;
#endif /* CONFIG_BLUETOOTH_BRIDGE_BTSNOOP */
- uint8_t refs;
+ atomic_uint refs;
Review Comment:
atomic_uint is defined by C11, but bt bridge is already guarded by BLUETOOTH_BRIDGE(disabled by default), do we need additional option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org