[jira] [Work logged] (BEAM-10887) FnApiTimer should expose clear() API

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-10887?focusedWorklogId=618247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618247 ]

ASF GitHub Bot logged work on BEAM-10887:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jul/21 20:17
            Start Date: 02/Jul/21 20:17
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on a change in pull request #15056:
URL: https://github.com/apache/beam/pull/15056#discussion_r663229663



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4851,6 +4851,342 @@ public void onTimer2(
         return PDone.in(input.getPipeline());
       }
     }
+

Review comment:
       I'm not sure how to guarantee that two timers are in the same bundle. Runners can bundle how they please, so simply advancing time to 3 provides no contract that timers A and B will in the same bundle.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 618247)
    Time Spent: 4h  (was: 3h 50m)

> FnApiTimer should expose clear() API
> ------------------------------------
>
>                 Key: BEAM-10887
>                 URL: https://issues.apache.org/jira/browse/BEAM-10887
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model, sdk-java-core
>            Reporter: Boyuan Zhang
>            Priority: P3
>              Labels: Clarified
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> Similar to python OutputTimer.clear():https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/worker/bundle_processor.py#L661, Java FnApiTimer should also expose clear() API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)