You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/22 14:58:18 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #649: Set CMAKE_EXPORT_COMPILE_COMMANDS to ON as a default behavior
PragmaTwice opened a new pull request, #649:
URL: https://github.com/apache/incubator-kvrocks/pull/649
Both clangd, clang-tidy and other language tools (like cppcheck) need compile_commands.json (a database for compile commands) to retrieve compile information like include dirs, standard, compile options, and more.
CMake provide an option CMAKE_EXPORT_COMPILE_COMMANDS to generate the file.
So setting it to ON as a default behavior can make these tools more easier to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #649: Set CMAKE_EXPORT_COMPILE_COMMANDS to ON as a default behavior
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #649:
URL: https://github.com/apache/incubator-kvrocks/pull/649#issuecomment-1163289769
> Could you describe a concrete use case that could benefits from this change? It seems we don't even configure `CMAKE_EXPORT_COMPILE_COMMANDS` for current cppcheck.
Yeah, cppcheck allow user to not provide a `compile_commands.json`, but it will greatly affect the detection accuracy, and user need to provide all include dirs, standard, compile options manually to fix this.
In static analysis and language server of C++, `compile_commands.json` is just a standard.
Many C++ project like apache/doris, oneflow, clickhouse did something like this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #649: Set CMAKE_EXPORT_COMPILE_COMMANDS to ON as a default behavior
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #649:
URL: https://github.com/apache/incubator-kvrocks/pull/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org