Re: [PR] docs: Add more technical detail and new diagram to Comet plugin overview [datafusion-comet]

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #1119:
URL: https://github.com/apache/datafusion-comet/pull/1119#discussion_r1867112281


##########
docs/source/contributor-guide/plugin_overview.md:
##########
@@ -64,25 +74,52 @@ of this could outweigh the benefits of running parts of the query stage natively
 
 ## Query Execution
 
-Once the plan has been transformed, any consecutive Comet operators are combined into a `CometNativeExec` which contains
-a serialized version of the plan (the serialization code can be found in `QueryPlanSerde`). When this operator is
-executed, the serialized plan is passed to the native code when calling `Native.createPlan`.
+Once the plan has been transformed, any consecutive native Comet operators are combined into a `CometNativeExec` which contains
+a protocol buffer serialized version of the plan (the serialization code can be found in `QueryPlanSerde`).
+
+Spark serializes the physical plan and sends it to the executors when executing tasks. The executors deserialize the
+plan and invoke it.
+
+When `CometNativeExec` is invoked, it will deserialize the protobuf plan and pass it into

Review Comment:
   I think `CometNativeExec` doesn't deserialize the protobuf plan. It is deserialized in native.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org