You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2008/08/11 15:42:55 UTC
DO NOT REPLY [Bug 45613] New: use of generics in package
org.apache.tomcat.util.http
https://issues.apache.org/bugzilla/show_bug.cgi?id=45613
Summary: use of generics in package org.apache.tomcat.util.http
Product: Tomcat 6
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: j.kapitza@schwarze-allianz.de
Created an attachment (id=22427)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=22427)
org.apache.tomcat.util.http patch
changes are:
org.apache.tomcat.util.collections can be deletet, because just MultiMap was
referenced but not used in Parameters.java
avoid dublicated creation of default language in AcceptLanguage
use java generics
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45613] use of generics in package
org.apache.tomcat.util.http
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45613
Jens Kapitza <j....@schwarze-allianz.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22431|0 |1
is obsolete| |
--- Comment #5 from Jens Kapitza <j....@schwarze-allianz.de> 2008-08-12 13:49:46 PST ---
Created an attachment (id=22440)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=22440)
remove formating
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45613] use of generics in package
org.apache.tomcat.util.http
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45613
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #6 from Mark Thomas <ma...@apache.org> 2008-11-19 15:18:09 PST ---
The patch still contains more than just the generics.
I have recently been through the code and fixed all the generics issues in this
package.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45613] use of generics in package
org.apache.tomcat.util.http
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45613
Jens Kapitza <j....@schwarze-allianz.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22427|0 |1
is obsolete| |
Attachment #22430|0 |1
is obsolete| |
--- Comment #3 from Jens Kapitza <j....@schwarze-allianz.de> 2008-08-12 09:31:51 PST ---
Created an attachment (id=22431)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=22431)
formating
last tabs removed
thanks for the information
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45613] use of generics in package
org.apache.tomcat.util.http
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45613
--- Comment #4 from Mark Thomas <ma...@apache.org> 2008-08-12 12:13:11 PST ---
Can you remove the code formatting changes? Your first patch was much easier to
review. The later patches hid all the interesting stuff in amongst a huge
volume of cosmetic changes.
Generally, we try and keep large cosmetic changes as completely separate
patches so all we have to do to review them is skim them to check no code has
changed. I did notice you were using a format for javadoc parameters that uses
a lot of whitespace. Also, it isn't a format that I am aware of us using
anywhere else in the codebase.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45613] use of generics in package
org.apache.tomcat.util.http
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45613
--- Comment #2 from Jens Kapitza <j....@schwarze-allianz.de> 2008-08-12 08:31:15 PST ---
Created an attachment (id=22430)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=22430)
with fixes (use of isSpace) changed to Spaces in Format
Format changes
remove unneded comments
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45613] use of generics in package
org.apache.tomcat.util.http
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45613
--- Comment #1 from Mark Thomas <ma...@apache.org> 2008-08-12 07:35:52 PST ---
There is some useful work here but also a few things that need to be fixed
before it can be applied to trunk:
- changes such as the one in MimeMap (Hashtable->Map) may break other users of
this class
- Character.isSpace() is not the same as Character.isWhitespace() (I got
caught out by this a while back)
- Don't comment out code to remove it - delete it. svn can tell us what has
changed and it makes the new code easier to read
- Where the debug field for logging has been removed, the replacement log
messages should all be log.debug(...)
- Spaces are replaced with a tab in at least one place. Tomcat always uses
spaces
Thanks for your efforts so far.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org