You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/10 13:25:04 UTC
[GitHub] [flink] MartijnVisser opened a new pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
MartijnVisser opened a new pull request #18316:
URL: https://github.com/apache/flink/pull/18316
## What is the purpose of the change
* This PR addresses multiple broken links (404s) existing throughout the English and Chinese documentation.
## Brief change log
* Fixed outdated links to new links
* Re-introduced `Idle State Retention Time` in Table/SQL configuration to fix numerous links to this doc
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
}, {
"hash" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 716ceb4e65626fde5dee8a5f0b11c6ed266e40fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177)
* 40a6f16a2126db71bc34c019294f7d4f8294542c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 716ceb4e65626fde5dee8a5f0b11c6ed266e40fd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
}, {
"hash" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580",
"triggerID" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"triggerType" : "PUSH"
}, {
"hash" : "207bde657043bade3a73aa158f5c72b33b9687a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29770",
"triggerID" : "207bde657043bade3a73aa158f5c72b33b9687a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 40a6f16a2126db71bc34c019294f7d4f8294542c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580)
* 207bde657043bade3a73aa158f5c72b33b9687a5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r781188418
##########
File path: docs/content.zh/docs/dev/table/config.md
##########
@@ -91,6 +91,39 @@ Flink SQL> SET 'table.exec.mini-batch.size' = '5000';
{{< /tab >}}
{{< /tabs >}}
+### Idle State Retention Time
+
+Many queries aggregate or join records on one or more key attributes. When such a query is executed
+on a stream, the continuous query needs to collect records or maintain partial results per key.
+If the key domain of the input stream is evolving, i.e., the active key values are changing over
+time, the continuous query accumulates more and more state as more and more distinct keys are
+observed. However, often keys become inactive after some time and their corresponding state
+becomes stale and useless.
+
+For example the following query computes the number of clicks per session.
+
+```sql
+SELECT sessionId, COUNT(*) FROM clicks GROUP BY sessionId;
+```
+
+The `sessionId` attribute is used as a grouping key and the continuous query maintains a count
+for each `sessionId` it observes. The `sessionId` attribute is evolving over time and `sessionId`
+values are only active until the session ends, i.e., for a limited period of time. However, the
+continuous query cannot know about this property of `sessionId` and expects that every `sessionId`
+value can occur at any point of time. It maintains a count for each observed `sessionId` value.
+Consequently, the total state size of the query is continuously growing as more and more `sessionId`
+values are observed.
+
+The *Idle State Retention Time* parameter [`table.exec.state.ttl`]({{< ref "docs/dev/table/config" >}}#table-exec-state-ttl)
+define for how long the state of a key is retained without being updated before it is removed.
+For the previous example query, the count of a`sessionId` would be removed as soon as it has not
+been updated for the configured period of time.
+
+By removing the state of a key, the continuous query completely forgets that it has seen this key
+before. If a record with a key, whose state has been removed before, is processed, the record will
+be treated as if it was the first record with the respective key. For the example above this means
+that the count of a `sessionId` would start again at `0`.
+
Review comment:
@twalthr This is the re-introduction of the documentation that was removed, to make sure that the relevant part of 'Query Configuration' now has a good documentation spot again and all broken links point to this documentation again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 716ceb4e65626fde5dee8a5f0b11c6ed266e40fd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r785818885
##########
File path: docs/layouts/shortcodes/query_state_warning.html
##########
@@ -16,5 +16,7 @@
specific language governing permissions and limitations
under the License.
*/}}
-For streaming queries the required state to compute the query result might grow infinitely depending on the type of aggregation and the number of distinct grouping keys. Please provide a query configuration with valid retention interval to prevent excessive state size.
-See <a href="/docs/dev/table/streaming/query_configuration">Query Configuration</a> for details.
+For streaming queries the required state to compute the query result might grow infinitely depending
+on the type of aggregation and the number of distinct grouping keys. Please provide a query
+configuration with valid retention interval to prevent excessive state size.
+See <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/table/config/#idle-state-retention-time">Query Configuration</a> for details.
Review comment:
This was part of an class called `Query Configuration`. Maybe update the title as well.
##########
File path: docs/content.zh/release-notes/flink-1.10.md
##########
@@ -179,7 +179,7 @@ If you try to reuse your previous Flink configuration without any adjustments,
the new memory model can result in differently computed memory parameters for
the JVM and, thus, performance changes.
-Please, check [the user documentation](../deployment/memory/mem_setup.html) for more details.
+Please, check [the user documentation](https://nightlies.apache.org/flink/flink-docs-release-1.10/ops/memory/mem_setup.html) for more details.
Review comment:
why a hard link here? in case we should link to something stable and not nightly?
##########
File path: docs/content/docs/dev/table/config.md
##########
@@ -98,6 +96,39 @@ Flink SQL> SET 'table.exec.mini-batch.size' = '5000';
{{< /tab >}}
{{< /tabs >}}
+### Idle State Retention Time
Review comment:
This was put under the `Streaming Concepts` section before. I'm fine with leaving it here. But we should make sure that this is for streaming only? We also have a `State Management` section in Streaming Concepts Overview?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
}, {
"hash" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580",
"triggerID" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 716ceb4e65626fde5dee8a5f0b11c6ed266e40fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177)
* 40a6f16a2126db71bc34c019294f7d4f8294542c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r786094121
##########
File path: docs/layouts/shortcodes/query_state_warning.html
##########
@@ -16,5 +16,7 @@
specific language governing permissions and limitations
under the License.
*/}}
-For streaming queries the required state to compute the query result might grow infinitely depending on the type of aggregation and the number of distinct grouping keys. Please provide a query configuration with valid retention interval to prevent excessive state size.
-See <a href="/docs/dev/table/streaming/query_configuration">Query Configuration</a> for details.
+For streaming queries the required state to compute the query result might grow infinitely depending
+on the type of aggregation and the number of distinct grouping keys. Please provide a query
+configuration with valid retention interval to prevent excessive state size.
+See <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/table/config/#idle-state-retention-time">Query Configuration</a> for details.
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
}, {
"hash" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580",
"triggerID" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"triggerType" : "PUSH"
}, {
"hash" : "207bde657043bade3a73aa158f5c72b33b9687a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "207bde657043bade3a73aa158f5c72b33b9687a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 40a6f16a2126db71bc34c019294f7d4f8294542c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580)
* 207bde657043bade3a73aa158f5c72b33b9687a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008875688
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 716ceb4e65626fde5dee8a5f0b11c6ed266e40fd (Mon Jan 10 13:29:49 UTC 2022)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
}, {
"hash" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580",
"triggerID" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 40a6f16a2126db71bc34c019294f7d4f8294542c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r787926866
##########
File path: docs/content.zh/docs/dev/table/config.md
##########
@@ -91,6 +91,39 @@ Flink SQL> SET 'table.exec.mini-batch.size' = '5000';
{{< /tab >}}
{{< /tabs >}}
+### Idle State Retention Time
Review comment:
did you forgot to update the Chinese version again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r785826257
##########
File path: docs/content.zh/release-notes/flink-1.10.md
##########
@@ -179,7 +179,7 @@ If you try to reuse your previous Flink configuration without any adjustments,
the new memory model can result in differently computed memory parameters for
the JVM and, thus, performance changes.
-Please, check [the user documentation](../deployment/memory/mem_setup.html) for more details.
+Please, check [the user documentation](https://nightlies.apache.org/flink/flink-docs-release-1.10/ops/memory/mem_setup.html) for more details.
Review comment:
This link is specifically in the Flink 1.10 release notes. My concern is that if something gets removed or changed in a future version, the message from the release notes could be confusing because a newer page might have different content on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18316:
URL: https://github.com/apache/flink/pull/18316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r788514647
##########
File path: docs/content.zh/docs/dev/table/config.md
##########
@@ -91,6 +91,39 @@ Flink SQL> SET 'table.exec.mini-batch.size' = '5000';
{{< /tab >}}
{{< /tabs >}}
+### Idle State Retention Time
Review comment:
Yes :( But I also noticed that we have a lot of content missing on the overview page, so I've copied & pasted the English content and opened https://issues.apache.org/jira/browse/FLINK-25716 to translate that page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 716ceb4e65626fde5dee8a5f0b11c6ed266e40fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r786079909
##########
File path: docs/content/docs/dev/table/config.md
##########
@@ -98,6 +96,39 @@ Flink SQL> SET 'table.exec.mini-batch.size' = '5000';
{{< /tab >}}
{{< /tabs >}}
+### Idle State Retention Time
Review comment:
Good point. I'm going to move it under `State Management`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18316:
URL: https://github.com/apache/flink/pull/18316#discussion_r785827085
##########
File path: docs/layouts/shortcodes/query_state_warning.html
##########
@@ -16,5 +16,7 @@
specific language governing permissions and limitations
under the License.
*/}}
-For streaming queries the required state to compute the query result might grow infinitely depending on the type of aggregation and the number of distinct grouping keys. Please provide a query configuration with valid retention interval to prevent excessive state size.
-See <a href="/docs/dev/table/streaming/query_configuration">Query Configuration</a> for details.
+For streaming queries the required state to compute the query result might grow infinitely depending
+on the type of aggregation and the number of distinct grouping keys. Please provide a query
+configuration with valid retention interval to prevent excessive state size.
+See <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/table/config/#idle-state-retention-time">Query Configuration</a> for details.
Review comment:
You mean something like this?
```suggestion
See <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/table/config/#idle-state-retention-time">Idle State Retention Time</a> for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18316: [hotfix][docs] Fixing multiple internal and external 404 links
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18316:
URL: https://github.com/apache/flink/pull/18316#issuecomment-1008874978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29177",
"triggerID" : "716ceb4e65626fde5dee8a5f0b11c6ed266e40fd",
"triggerType" : "PUSH"
}, {
"hash" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29580",
"triggerID" : "40a6f16a2126db71bc34c019294f7d4f8294542c",
"triggerType" : "PUSH"
}, {
"hash" : "207bde657043bade3a73aa158f5c72b33b9687a5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29770",
"triggerID" : "207bde657043bade3a73aa158f5c72b33b9687a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 207bde657043bade3a73aa158f5c72b33b9687a5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org