You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jhorstmann (via GitHub)" <gi...@apache.org> on 2024/01/30 14:19:40 UTC

[PR] Mark Encoding::BIT_PACKED as deprecated and document its compatibility issues [arrow-rs]

jhorstmann opened a new pull request, #5348:
URL: https://github.com/apache/arrow-rs/pull/5348

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Related to #5338.
   
   # Rationale for this change
   
   This marks `Encoding::BIT_PACKED` as deprecated, so that users will get notified if they explicitly use it for a v1 `LevelEncoder`.
   
   We probably can't remove or fix the encoding without a lengthy deprecation cycle since users might want to roundtrip existing files using the incorrect bit order, but they should at least be made aware of the compatibility issues.
   
   The `encoding` module should be behind the `experimental` feature flag, so hopefully not many people are using this api and we might be able to create a spec compliant implementation in the future.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Mark Encoding::BIT_PACKED as deprecated and document its compatibility issues [arrow-rs]

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #5348:
URL: https://github.com/apache/arrow-rs/pull/5348#issuecomment-1917207264

   Ah you're right, boolean PLAIN will pack into bits, but encoding is PLAIN, my bad.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Mark Encoding::BIT_PACKED as deprecated and document its compatibility issues [arrow-rs]

Posted by "jhorstmann (via GitHub)" <gi...@apache.org>.
jhorstmann commented on PR #5348:
URL: https://github.com/apache/arrow-rs/pull/5348#issuecomment-1917090562

   > Seems that BIT_PACKED can be used for boolean data, would that also be deprecated?
   
   Boolean columns use either `PLAIN` or `RLE` encoding, where the `PLAIN` encoding is actually using bitpacking starting from the least-significant bit. I think the documentation for this is confusing since `PLAIN` Boolean links to the deprecated bit-packed encoding, followed by the note "LSB first", making this a quite different encoding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Mark Encoding::BIT_PACKED as deprecated and document its compatibility issues [arrow-rs]

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #5348:
URL: https://github.com/apache/arrow-rs/pull/5348#issuecomment-1917005958

   Seems that BIT_PACKED can be used for boolean data, would that also be deprecated?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Mark Encoding::BIT_PACKED as deprecated and document its compatibility issues [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #5348:
URL: https://github.com/apache/arrow-rs/pull/5348


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org