[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
URL: https://github.com/apache/airflow/pull/6850#discussion_r362745659
 
 

 ##########
 File path: setup.py
 ##########
 @@ -275,6 +275,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
 ]
 mssql = [
     'pymssql~=2.1.1',
+    'pyodbc',
 
 Review comment:
   > DbAPIHook provides SQL Alchemy engine but then we replace it with specific libraries in the hooks that re-implement it.
   
   DBAPI hook does not provide an engine -- it just provides a standard way to produce the engine given a URI.  each hook may need to URI in different way.  but engine generation doesn't care about those details. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services