You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vladimirg-db (via GitHub)" <gi...@apache.org> on 2025/02/09 15:03:44 UTC

[PR] [SPARK-51135][SQL] Fix ViewResolverSuite for ANSI modes [spark]

vladimirg-db opened a new pull request, #49857:
URL: https://github.com/apache/spark/pull/49857

   ### What changes were proposed in this pull request?
   
   Fix `ViewResolverSuite` for non-ANSI mode. View column `Cast`s have have ANSI evaluation in non-ANSI mode when view schema `COMPENSATION` is the default view schema mode: https://github.com/apache/spark/blob/301b666a1fcbd4c59d96c53fe3a547ea1512f397/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala#L965.
   
   Also, use `dsl` package to simplify test code.
   
   ### Why are the changes needed?
   
   To fix tests in non-ANSI mode: https://github.com/apache/spark/pull/49658#discussion_r1944266007
   
   ### Does this PR introduce _any_ user-facing change?
   
   Just a test suite change.
   
   ### How was this patch tested?
   
   Fixed the `ViewResolverSuite`.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   copilot.nvim.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51135][SQL] Fix ViewResolverSuite for ANSI modes [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #49857: [SPARK-51135][SQL] Fix ViewResolverSuite for ANSI modes
URL: https://github.com/apache/spark/pull/49857


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51135][SQL] Fix ViewResolverSuite for ANSI modes [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #49857:
URL: https://github.com/apache/spark/pull/49857#issuecomment-2646800076

   thanks, merging to master/4.0!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org