You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/07/31 16:45:00 UTC

[jira] [Commented] (AVRO-3801) Modify Schema.Parser.addTypes signature

    [ https://issues.apache.org/jira/browse/AVRO-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749278#comment-17749278 ] 

ASF subversion and git services commented on AVRO-3801:
-------------------------------------------------------

Commit ab6e1b8239a05c15fc7652784234408a41df5606 in avro's branch refs/heads/master from Christophe Le Saec
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ab6e1b823 ]

AVRO-3801: change method signature


> Modify Schema.Parser.addTypes signature
> ---------------------------------------
>
>                 Key: AVRO-3801
>                 URL: https://issues.apache.org/jira/browse/AVRO-3801
>             Project: Apache Avro
>          Issue Type: Improvement
>            Reporter: Christophe Le Saec
>            Assignee: Christophe Le Saec
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> On java module, method addTypes is defined with a Map as input parameter
> {code:java}
> public Parser addTypes(Map<String, Schema> types) {
> {code}
> But key is never used.
> So, very basic, simple improvement, is to change to 
> {code:java}
> public Parser addTypes(Iterabler<Schema> types) {
> {code}
> (keeping current one as deprecated for backward compatibility purpose)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)