You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 03:42:07 UTC
[GitHub] [arrow] domoritz opened a new pull request, #12858: ARROW-16167: [JS] refactor get and set visitors
domoritz opened a new pull request, #12858:
URL: https://github.com/apache/arrow/pull/12858
It doesn't seem to make measurable performance differences but the code is more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz closed pull request #12858: ARROW-16167: [JS] refactor get and set visitors
Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #12858: ARROW-16167: [JS] refactor get and set visitors
URL: https://github.com/apache/arrow/pull/12858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12858: ARROW-16167: [JS] refactor get and set visitors
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12858:
URL: https://github.com/apache/arrow/pull/12858#issuecomment-1099681087
Benchmark runs are scheduled for baseline = 9d24ded7f7d58717c9d78308b0c59ab7a9636006 and contender = 62d0b17989bc624abf1a33215b4fba8915512f3b. 62d0b17989bc624abf1a33215b4fba8915512f3b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ec04896c71ff4b8482bf36d00a87e04f...fa8210e354b44fb6b0bb053b891dfc93/)
[Finished :arrow_down:0.21% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/24680a30cc9a4292aac0fbdc01945061...f0e7b25bd45c43aba319acc2c7eb57e4/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/190b365264bc48d1a96f5711875a1701...f21df952cb5f4aeb815cfb6d0fa58fd6/)
[Finished :arrow_down:0.51% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d3d34794a0644ea3946f5da4f4407516...fbf1e169a3724bc09925be016797e843/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/506| `62d0b179` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/493| `62d0b179` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/492| `62d0b179` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/503| `62d0b179` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/505| `9d24ded7` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/492| `9d24ded7` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/491| `9d24ded7` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/502| `9d24ded7` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12858: ARROW-16167: [JS] refactor get and set visitors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12858:
URL: https://github.com/apache/arrow/pull/12858#issuecomment-1095948527
https://issues.apache.org/jira/browse/ARROW-16167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org