You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/12/08 23:58:15 UTC
Review Request 28829: SAMZA-495
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28829/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-495
https://issues.apache.org/jira/browse/SAMZA-495
Repository: samza-hello-samza
Description
-------
re-add samza-serializers
merge latest into master. edit bin/grid to not install samza. update .reviewboardrc to point to master. update pom.xml to point to 0.8.0, not snapshot.
Diffs
-----
.gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
bin/grid 4324c9278e88de4fed8ab2d63f14201613b43eaa
pom.xml 90f6c034547861f067c082268c713a67fad17597
samza-job-package/pom.xml 169a28f08e4e532a4dcf75e1b4fdcce475c38228
samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259
samza-job-package/src/main/config/wikipedia-feed.properties
samza-job-package/src/main/config/wikipedia-parser.properties
samza-job-package/src/main/config/wikipedia-stats.properties be0c749e29e2545a9aba2a55246e6f323204f8ec
samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053
samza-wikipedia/pom.xml 20d94ed7f7624a1b9341eed90b7a2734249ef857
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
Diff: https://reviews.apache.org/r/28829/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 28829: SAMZA-495
Posted by Chris Riccomini <cr...@apache.org>.
> On Dec. 9, 2014, 5:17 p.m., Chinmay Soman wrote:
> > pom.xml, line 119
> > <https://reviews.apache.org/r/28829/diff/2/?file=786063#file786063line119>
> >
> > Why do we need hdfs ?
That's there so this:
http://samza.incubator.apache.org/learn/tutorials/0.8/deploy-samza-job-from-hdfs.html
Will work.
> On Dec. 9, 2014, 5:17 p.m., Chinmay Soman wrote:
> > pom.xml, line 84
> > <https://reviews.apache.org/r/28829/diff/2/?file=786063#file786063line84>
> >
> > Why not RocksDB ?
Done.
> On Dec. 9, 2014, 5:17 p.m., Chinmay Soman wrote:
> > samza-job-package/src/main/config/wikipedia-stats.properties, line 50
> > <https://reviews.apache.org/r/28829/diff/2/?file=786068#file786068line50>
> >
> > Why not RocksDB ?
Done.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28829/#review64388
-----------------------------------------------------------
On Dec. 8, 2014, 11:02 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28829/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 11:02 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-495
> https://issues.apache.org/jira/browse/SAMZA-495
>
>
> Repository: samza-hello-samza
>
>
> Description
> -------
>
> fix serializers scala version
>
>
> re-add samza-serializers
>
>
> merge latest into master. edit bin/grid to not install samza. update .reviewboardrc to point to master. update pom.xml to point to 0.8.0, not snapshot.
>
>
> Diffs
> -----
>
> .gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
> bin/grid 4324c9278e88de4fed8ab2d63f14201613b43eaa
> pom.xml 90f6c034547861f067c082268c713a67fad17597
> samza-job-package/pom.xml 169a28f08e4e532a4dcf75e1b4fdcce475c38228
> samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259
> samza-job-package/src/main/config/wikipedia-feed.properties
> samza-job-package/src/main/config/wikipedia-parser.properties
> samza-job-package/src/main/config/wikipedia-stats.properties be0c749e29e2545a9aba2a55246e6f323204f8ec
> samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053
> samza-wikipedia/pom.xml 20d94ed7f7624a1b9341eed90b7a2734249ef857
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
>
> Diff: https://reviews.apache.org/r/28829/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 28829: SAMZA-495
Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28829/#review64388
-----------------------------------------------------------
pom.xml
<https://reviews.apache.org/r/28829/#comment107090>
Why not RocksDB ?
pom.xml
<https://reviews.apache.org/r/28829/#comment107091>
Why do we need hdfs ?
samza-job-package/src/main/config/wikipedia-stats.properties
<https://reviews.apache.org/r/28829/#comment107089>
Why not RocksDB ?
- Chinmay Soman
On Dec. 8, 2014, 11:02 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28829/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 11:02 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-495
> https://issues.apache.org/jira/browse/SAMZA-495
>
>
> Repository: samza-hello-samza
>
>
> Description
> -------
>
> fix serializers scala version
>
>
> re-add samza-serializers
>
>
> merge latest into master. edit bin/grid to not install samza. update .reviewboardrc to point to master. update pom.xml to point to 0.8.0, not snapshot.
>
>
> Diffs
> -----
>
> .gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
> bin/grid 4324c9278e88de4fed8ab2d63f14201613b43eaa
> pom.xml 90f6c034547861f067c082268c713a67fad17597
> samza-job-package/pom.xml 169a28f08e4e532a4dcf75e1b4fdcce475c38228
> samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259
> samza-job-package/src/main/config/wikipedia-feed.properties
> samza-job-package/src/main/config/wikipedia-parser.properties
> samza-job-package/src/main/config/wikipedia-stats.properties be0c749e29e2545a9aba2a55246e6f323204f8ec
> samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053
> samza-wikipedia/pom.xml 20d94ed7f7624a1b9341eed90b7a2734249ef857
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
>
> Diff: https://reviews.apache.org/r/28829/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 28829: SAMZA-495
Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28829/#review64407
-----------------------------------------------------------
Ship it!
Ship It!
- Chinmay Soman
On Dec. 9, 2014, 5:58 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28829/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 5:58 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-495
> https://issues.apache.org/jira/browse/SAMZA-495
>
>
> Repository: samza-hello-samza
>
>
> Description
> -------
>
> switch leveldb assembly to rocksdb
>
>
> switch leveldb to rocksdb
>
>
> fix serializers scala version
>
>
> re-add samza-serializers
>
>
> merge latest into master. edit bin/grid to not install samza. update .reviewboardrc to point to master. update pom.xml to point to 0.8.0, not snapshot.
>
>
> Diffs
> -----
>
> .gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
> bin/grid 4324c9278e88de4fed8ab2d63f14201613b43eaa
> pom.xml 90f6c034547861f067c082268c713a67fad17597
> samza-job-package/pom.xml 169a28f08e4e532a4dcf75e1b4fdcce475c38228
> samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259
> samza-job-package/src/main/config/wikipedia-feed.properties
> samza-job-package/src/main/config/wikipedia-parser.properties
> samza-job-package/src/main/config/wikipedia-stats.properties be0c749e29e2545a9aba2a55246e6f323204f8ec
> samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053
> samza-wikipedia/pom.xml 20d94ed7f7624a1b9341eed90b7a2734249ef857
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
>
> Diff: https://reviews.apache.org/r/28829/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 28829: SAMZA-495
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28829/
-----------------------------------------------------------
(Updated Dec. 9, 2014, 5:58 p.m.)
Review request for samza.
Bugs: SAMZA-495
https://issues.apache.org/jira/browse/SAMZA-495
Repository: samza-hello-samza
Description (updated)
-------
switch leveldb assembly to rocksdb
switch leveldb to rocksdb
fix serializers scala version
re-add samza-serializers
merge latest into master. edit bin/grid to not install samza. update .reviewboardrc to point to master. update pom.xml to point to 0.8.0, not snapshot.
Diffs (updated)
-----
.gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
bin/grid 4324c9278e88de4fed8ab2d63f14201613b43eaa
pom.xml 90f6c034547861f067c082268c713a67fad17597
samza-job-package/pom.xml 169a28f08e4e532a4dcf75e1b4fdcce475c38228
samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259
samza-job-package/src/main/config/wikipedia-feed.properties
samza-job-package/src/main/config/wikipedia-parser.properties
samza-job-package/src/main/config/wikipedia-stats.properties be0c749e29e2545a9aba2a55246e6f323204f8ec
samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053
samza-wikipedia/pom.xml 20d94ed7f7624a1b9341eed90b7a2734249ef857
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
Diff: https://reviews.apache.org/r/28829/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 28829: SAMZA-495
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28829/
-----------------------------------------------------------
(Updated Dec. 8, 2014, 11:02 p.m.)
Review request for samza.
Bugs: SAMZA-495
https://issues.apache.org/jira/browse/SAMZA-495
Repository: samza-hello-samza
Description (updated)
-------
fix serializers scala version
re-add samza-serializers
merge latest into master. edit bin/grid to not install samza. update .reviewboardrc to point to master. update pom.xml to point to 0.8.0, not snapshot.
Diffs (updated)
-----
.gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
bin/grid 4324c9278e88de4fed8ab2d63f14201613b43eaa
pom.xml 90f6c034547861f067c082268c713a67fad17597
samza-job-package/pom.xml 169a28f08e4e532a4dcf75e1b4fdcce475c38228
samza-job-package/src/main/assembly/src.xml 14a5ad511ce06763776a1ea2e94346a622a54259
samza-job-package/src/main/config/wikipedia-feed.properties
samza-job-package/src/main/config/wikipedia-parser.properties
samza-job-package/src/main/config/wikipedia-stats.properties be0c749e29e2545a9aba2a55246e6f323204f8ec
samza-job-package/src/main/resources/log4j.xml a9371655e8edd2426aff113dc33f481d7a2aa053
samza-wikipedia/pom.xml 20d94ed7f7624a1b9341eed90b7a2734249ef857
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
Diff: https://reviews.apache.org/r/28829/diff/
Testing
-------
Thanks,
Chris Riccomini