You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/02/10 22:25:02 UTC
[GitHub] brooklyn-server pull request #556: Speed up tests
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/556
Speed up tests
Starting an embedded OSGi container is slow - over half a second per `setUp()` call (and thus per test method) that uses it. It will likely be considerably slower on the jenkins build machine etc. This PR separates out those classes that include an embedded OSGi container into those tests that actually need it and those that don't. It primarily moves code around (e.g. separating out the osgi-based tests from `CatalogYamlLocationTest` into a new `CatalogOsgiYamlLocationTest`).
It also cherry-pick @ahgittin's commit that was included in https://github.com/apache/brooklyn-server/pull/480 (which marks some more slow tests as "integration").
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server speedup-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #556
----
commit 7ff81869bbc6dbef9f7baf0c9211c75f2b0ea7e5
Author: Aled Sage <al...@gmail.com>
Date: 2017-02-10T14:21:11Z
Split CatalogYamlLocationTest for non-osgi and osgi
commit f2ea02d5ac653a5b0d3db80c8e582cf0b096cf20
Author: Aled Sage <al...@gmail.com>
Date: 2017-02-10T14:34:56Z
Split CatalogYamlPolicyTest for non-osgi and osgi
commit 27ad37cd39b7b133a454f6e9b5d05eaedc0dc3d6
Author: Aled Sage <al...@gmail.com>
Date: 2017-02-10T14:50:26Z
Split CatalogYamlTemplateTest for non-osgi and osgi
commit c5ae189c544dc1dc48a37d5537b86488a33e75ec
Author: Aled Sage <al...@gmail.com>
Date: 2017-02-10T14:06:34Z
Split CatalogYamlEntityTest for non-osgi and osgi
commit 29191b76b403a5fea58e0e4fcab9a7eb926bbe8c
Author: Alex Heneveld <al...@alexs-macbook-pro.local>
Date: 2016-12-07T00:46:13Z
slow tests moved to integration group
commit 8f0021eddb3df379dad227c31b9f4b29e9dfaeba
Author: Aled Sage <al...@gmail.com>
Date: 2017-02-10T21:55:56Z
Split ReferencedYamlTest for non-osgi and osgi
commit f73d2c81402d098a184dbfe2e8af0dceb9bf6e64
Author: Aled Sage <al...@gmail.com>
Date: 2017-02-10T21:56:32Z
Split SpecParameterParsingTest for non-osgi and osgi
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #556: Speed up tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #556: Speed up tests
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/556
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---