You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Jarek Cecho <ja...@apache.org> on 2014/06/08 22:28:38 UTC
Review Request 22358: SENTRY-166 Sentry does not accept URIs with an equals
sign (=) in path. Fails with llegalArgumentException: Invalid key value
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22358/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-166
https://issues.apache.org/jira/browse/SENTRY-166
Repository: sentry
Description
-------
I've fixed the problem by setting a limit to 2 on splitting the key-value pair.
Diffs
-----
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java efc5671
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/KeyValue.java 622736a
sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/TestKeyValue.java 1d8c9ae
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java dd45a31
Diff: https://reviews.apache.org/r/22358/diff/
Testing
-------
Added multiple tests to ensure that this functionality will work end to end. I've also rerun all Hive E2E tests to ensure that we won't regress (which seems to be the case).
Thanks,
Jarek Cecho
Re: Review Request 22358: SENTRY-166 Sentry does not accept URIs with an
equals sign (=) in path. Fails with llegalArgumentException: Invalid key
value
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22358/#review45044
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On June 8, 2014, 8:28 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22358/
> -----------------------------------------------------------
>
> (Updated June 8, 2014, 8:28 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-166
> https://issues.apache.org/jira/browse/SENTRY-166
>
>
> Repository: sentry
>
>
> Description
> -------
>
> I've fixed the problem by setting a limit to 2 on splitting the key-value pair.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java efc5671
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/KeyValue.java 622736a
> sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/TestKeyValue.java 1d8c9ae
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java dd45a31
>
> Diff: https://reviews.apache.org/r/22358/diff/
>
>
> Testing
> -------
>
> Added multiple tests to ensure that this functionality will work end to end. I've also rerun all Hive E2E tests to ensure that we won't regress (which seems to be the case).
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 22358: SENTRY-166 Sentry does not accept URIs with an
equals sign (=) in path. Fails with llegalArgumentException: Invalid key
value
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22358/#review45045
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On June 8, 2014, 9:22 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22358/
> -----------------------------------------------------------
>
> (Updated June 8, 2014, 9:22 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-166
> https://issues.apache.org/jira/browse/SENTRY-166
>
>
> Repository: sentry
>
>
> Description
> -------
>
> I've fixed the problem by setting a limit to 2 on splitting the key-value pair.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java efc5671
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/KeyValue.java 622736a
> sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/TestKeyValue.java 1d8c9ae
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java dd45a31
>
> Diff: https://reviews.apache.org/r/22358/diff/
>
>
> Testing
> -------
>
> Added multiple tests to ensure that this functionality will work end to end. I've also rerun all Hive E2E tests to ensure that we won't regress (which seems to be the case).
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 22358: SENTRY-166 Sentry does not accept URIs with an
equals sign (=) in path. Fails with llegalArgumentException: Invalid key
value
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22358/
-----------------------------------------------------------
(Updated June 8, 2014, 9:22 p.m.)
Review request for sentry.
Changes
-------
Removed outdated test.
Bugs: SENTRY-166
https://issues.apache.org/jira/browse/SENTRY-166
Repository: sentry
Description
-------
I've fixed the problem by setting a limit to 2 on splitting the key-value pair.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java efc5671
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/KeyValue.java 622736a
sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/TestKeyValue.java 1d8c9ae
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java dd45a31
Diff: https://reviews.apache.org/r/22358/diff/
Testing
-------
Added multiple tests to ensure that this functionality will work end to end. I've also rerun all Hive E2E tests to ensure that we won't regress (which seems to be the case).
Thanks,
Jarek Cecho