You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Henry Saputra (JIRA)" <ji...@apache.org> on 2011/04/11 21:34:05 UTC

[jira] [Commented] (SHINDIG-1522) DefaultIframeUriManager does not handle locked domains with port numbers

    [ https://issues.apache.org/jira/browse/SHINDIG-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018525#comment-13018525 ] 

Henry Saputra commented on SHINDIG-1522:
----------------------------------------

I think this is fixed with rev  r1089708:

Patch from Stanton Sievers | DefaultIframeUriManager changes for handling locked domains"

http://codereview.appspot.com/4343053/

Modified:
   shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
   shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java


> DefaultIframeUriManager does not handle locked domains with port numbers
> ------------------------------------------------------------------------
>
>                 Key: SHINDIG-1522
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1522
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Stanton Sievers
>            Priority: Minor
>             Fix For: 3.0.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Currently, specifying a gadgets.uri.iframe.lockedDomainSuffix with a port number in one's container.js causes an
> exception to be thrown when using the DefaultIframeUriManager and the
> DefaultUriParser.  The problem is that such URLs are parsed as opaque and opaque
> URLs are not allowed by the default parser.
> Patch here: http://codereview.appspot.com/4343053/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira