[GitHub] [gobblin] homatthew commented on a diff in pull request #3704: Py helix scheduler throttle gobblin 1840

["homatthew (via GitHub)" <gi...@apache.org>]

homatthew commented on code in PR #3704:
URL: https://github.com/apache/gobblin/pull/3704#discussion_r1229996447


##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java:
##########
@@ -110,14 +113,16 @@ public class GobblinHelixJobScheduler extends JobScheduler implements StandardMe
 
   private boolean startServicesCompleted;
   private final long helixJobStopTimeoutMillis;
+  private final Duration throttleTimeoutDuration;
+  private ConcurrentHashMap<String, Instant> jobStartTimeMap;
 
   public GobblinHelixJobScheduler(Config sysConfig,
-                                  HelixManager jobHelixManager,
-                                  Optional<HelixManager> taskDriverHelixManager,
-                                  EventBus eventBus,
-                                  Path appWorkDir, List<? extends Tag<?>> metadataTags,
-                                  SchedulerService schedulerService,
-                                  MutableJobCatalog jobCatalog) throws Exception {
+      HelixManager jobHelixManager,

Review Comment:
   Let's revert random whitespace changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org