[GitHub] wujimin commented on a change in pull request #886: [SCB-880]Give an option to query parameter convert empty to null

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #886: [SCB-880]Give an option to query parameter convert empty to null
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/886#discussion_r213949298
 
 

 ##########
 File path: common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/QueryProcessorCreator.java
 ##########
 @@ -44,6 +46,13 @@ public Object getValue(HttpServletRequest request) throws Exception {
         value = request.getParameterValues(paramPath);
       } else {
         value = request.getParameter(paramPath);
+        // make some old systems happy
+        if (DynamicPropertyFactory.getInstance()
 
 Review comment:
   every time invoke DynamicPropertyFactory.getInstance().getBooleanProperty, will:
   1.create a instance of DynamicBooleanProperty
   2.three times map search at least
   
   and this value almost not changed, better to cache it and update by callback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services