You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/27 09:37:39 UTC

[GitHub] [dubbo] changfubai opened a new pull request #8623: fix issue-8516 on 2.6.x: fix mock:true configuration

changfubai opened a new pull request #8623:
URL: https://github.com/apache/dubbo/pull/8623


   fix #8516 on branch 2.6.x.
   ps: this commit has been merge into 3.0 and master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8623: fix issue-8516 on 2.6.x: fix mock:true configuration

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8623:
URL: https://github.com/apache/dubbo/pull/8623#issuecomment-907074685


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8623](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35fed07) into [2.6.x](https://codecov.io/gh/apache/dubbo/commit/f62ca3f71a6db624cd4e3b23a58ed7dacf736d91?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f62ca3f) will **increase** coverage by `0.34%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8623/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##              2.6.x    #8623      +/-   ##
   ============================================
   + Coverage     47.04%   47.39%   +0.34%     
   - Complexity     4472     4519      +47     
   ============================================
     Files           577      577              
     Lines         25631    25632       +1     
     Branches       4546     4547       +1     
   ============================================
   + Hits          12059    12148      +89     
   + Misses        11710    11602     -108     
   - Partials       1862     1882      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/com/alibaba/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvc3VwcG9ydC9Nb2NrSW52b2tlci5qYXZh) | `57.40% <66.66%> (+57.40%)` | :arrow_up: |
   | [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `42.25% <0.00%> (-11.27%)` | :arrow_down: |
   | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `87.85% <0.00%> (-1.87%)` | :arrow_down: |
   | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `58.46% <0.00%> (+1.53%)` | :arrow_up: |
   | [.../alibaba/dubbo/rpc/proxy/AbstractProxyFactory.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJveHkvQWJzdHJhY3RQcm94eUZhY3RvcnkuamF2YQ==) | `4.76% <0.00%> (+4.76%)` | :arrow_up: |
   | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `88.88% <0.00%> (+5.55%)` | :arrow_up: |
   | [...n/java/com/alibaba/dubbo/rpc/support/RpcUtils.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvc3VwcG9ydC9ScGNVdGlscy5qYXZh) | `27.02% <0.00%> (+6.75%)` | :arrow_up: |
   | [...src/main/java/com/alibaba/dubbo/rpc/RpcResult.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjUmVzdWx0LmphdmE=) | `46.15% <0.00%> (+7.69%)` | :arrow_up: |
   | [...main/java/com/alibaba/dubbo/rpc/RpcInvocation.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjSW52b2NhdGlvbi5qYXZh) | `25.55% <0.00%> (+10.00%)` | :arrow_up: |
   | [...bbo/rpc/proxy/wrapper/StubProxyFactoryWrapper.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJveHkvd3JhcHBlci9TdHViUHJveHlGYWN0b3J5V3JhcHBlci5qYXZh) | `18.42% <0.00%> (+18.42%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f62ca3f...35fed07](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #8623: fix issue-8516 on 2.6.x: fix mock:true configuration

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #8623:
URL: https://github.com/apache/dubbo/pull/8623


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8623: fix issue-8516 on 2.6.x: fix mock:true configuration

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8623:
URL: https://github.com/apache/dubbo/pull/8623#issuecomment-907074685


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8623](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35fed07) into [2.6.x](https://codecov.io/gh/apache/dubbo/commit/f62ca3f71a6db624cd4e3b23a58ed7dacf736d91?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f62ca3f) will **increase** coverage by `0.28%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8623/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##              2.6.x    #8623      +/-   ##
   ============================================
   + Coverage     47.04%   47.33%   +0.28%     
   - Complexity     4472     4515      +43     
   ============================================
     Files           577      577              
     Lines         25631    25604      -27     
     Branches       4546     4523      -23     
   ============================================
   + Hits          12059    12120      +61     
   + Misses        11710    11595     -115     
   - Partials       1862     1889      +27     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/com/alibaba/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvc3VwcG9ydC9Nb2NrSW52b2tlci5qYXZh) | `57.40% <66.66%> (+57.40%)` | :arrow_up: |
   | [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `42.25% <0.00%> (-11.27%)` | :arrow_down: |
   | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `80.00% <0.00%> (-7.50%)` | :arrow_down: |
   | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNoYW5uZWwuamF2YQ==) | `58.75% <0.00%> (-6.25%)` | :arrow_down: |
   | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
   | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `85.71% <0.00%> (-4.29%)` | :arrow_down: |
   | [...a/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlci5qYXZh) | `72.13% <0.00%> (-3.28%)` | :arrow_down: |
   | [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvTG9nVGVsbmV0SGFuZGxlci5qYXZh) | `68.57% <0.00%> (-2.86%)` | :arrow_down: |
   | [...a/com/alibaba/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvUmVxdWVzdC5qYXZh) | `80.95% <0.00%> (-2.39%)` | :arrow_down: |
   | [...bo/rpc/cluster/support/FailoverClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3N1cHBvcnQvRmFpbG92ZXJDbHVzdGVySW52b2tlci5qYXZh) | `82.22% <0.00%> (-2.23%)` | :arrow_down: |
   | ... and [23 more](https://codecov.io/gh/apache/dubbo/pull/8623/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f62ca3f...35fed07](https://codecov.io/gh/apache/dubbo/pull/8623?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org