You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2023/04/26 07:23:53 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
mrhhsg opened a new pull request, #19101:
URL: https://github.com/apache/doris/pull/19101
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #19101:
URL: https://github.com/apache/doris/pull/19101#discussion_r1177465945
##########
be/src/util/bitmap_value.h:
##########
@@ -1155,6 +1155,20 @@ class BitmapValue {
DCHECK(res);
}
+ BitmapValue(const BitmapValue& other) = default;
+ BitmapValue(BitmapValue&& other) {
+ std::swap(_type, other._type);
+ std::swap(_sv, other._sv);
+ std::swap(_bitmap, other._bitmap);
+ }
+
+ BitmapValue& operator=(const BitmapValue& other) {
+ _type = other._type;
+ _sv = other._sv;
+ _bitmap = other._bitmap;
+ return *this;
+ }
Review Comment:
warning: use '= default' to define a trivial copy-assignment operator [modernize-use-equals-default]
```suggestion
BitmapValue& operator=(const BitmapValue& other) = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1523019229
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1526923562
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19101:
URL: https://github.com/apache/doris/pull/19101#discussion_r1199599330
##########
be/src/util/bitmap_value.h:
##########
@@ -1876,14 +1912,27 @@ class BitmapValue {
return result;
}
+ void _prepare_bitmap_for_write() {
+ if (!_bitmap) {
+ _bitmap = std::make_shared<detail::Roaring64Map>();
+ return;
+ }
+
+ if (_bitmap.use_count() > 1) {
Review Comment:
感觉这里用use count 可能不太好,不如记录一个标记位,比如is_owner 这样的,然后再copy constructor 还有operator=的时候,都把is_owner 设置为false;prepare for write的时候,设置为true。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1560652432
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1533978662
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1556687822
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1556449901
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1534000790
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19101:
URL: https://github.com/apache/doris/pull/19101#discussion_r1199599453
##########
be/src/util/bitmap_value.h:
##########
@@ -1876,14 +1912,27 @@ class BitmapValue {
return result;
}
+ void _prepare_bitmap_for_write() {
+ if (!_bitmap) {
+ _bitmap = std::make_shared<detail::Roaring64Map>();
+ return;
+ }
+
+ if (_bitmap.use_count() > 1) {
Review Comment:
如果is owner == true,就直接return了。 我觉得一个bool 的判断效率要比 shared ptr use count 高
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1526809320
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1556983446
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.68 seconds
stream load tsv: 433 seconds loaded 74807831229 Bytes, about 164 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 80.4 seconds inserted 10000000 Rows, about 124K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230522103952_clickbench_pr_148293.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1556526165
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.94 seconds
stream load tsv: 423 seconds loaded 74807831229 Bytes, about 168 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 79.4 seconds inserted 10000000 Rows, about 125K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230522045521_clickbench_pr_148057.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1556840244
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19101:
URL: https://github.com/apache/doris/pull/19101#discussion_r1199942198
##########
be/src/util/bitmap_value.h:
##########
@@ -1155,6 +1155,45 @@ class BitmapValue {
DCHECK(res);
}
+ BitmapValue(const BitmapValue& other) {
+ _type = other._type;
+ _sv = other._sv;
+ _bitmap = other._bitmap;
+ _is_shared = true;
+ // should also set other's state to shared, so that other bitmap value will
+ // create a new bitmap when it wants to modify it.
+ const_cast<BitmapValue&>(other)._is_shared = true;
+ }
+
+ BitmapValue(BitmapValue&& other) {
+ _type = other._type;
+ _sv = other._sv;
+ _bitmap = std::move(other._bitmap);
Review Comment:
is shared = true or false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #19101:
URL: https://github.com/apache/doris/pull/19101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1533999824
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1523012193
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1522918100
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1556446703
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1560652365
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1533980617
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1526811460
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1526925874
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19101:
URL: https://github.com/apache/doris/pull/19101#discussion_r1199944810
##########
be/src/util/bitmap_value.h:
##########
@@ -1876,14 +1930,35 @@ class BitmapValue {
return result;
}
+ void _prepare_bitmap_for_write() {
+ if (!_bitmap) {
+ _bitmap = std::make_shared<detail::Roaring64Map>();
Review Comment:
_is_shared = false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19101: [improvement](bitmap) Use shared_ptr in BitmapValue to avoid deep copying
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19101:
URL: https://github.com/apache/doris/pull/19101#issuecomment-1523022772
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.36 seconds
stream load tsv: 424 seconds loaded 74807831229 Bytes, about 168 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230426084646_clickbench_pr_135595.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org